-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Hebrew.no_taamim fails with "AttributeError: 'str' object has no attribute 'string'" #19
Comments
Ok, my mistake. I didn't build an object from your class. That seems kind of heavy. Not sure why I can't just call a function.
I can also make my own function like this:
Then just do:
|
Hi there, I have looked at adding transliteration and recently got my hands on some source material that could help, but I haven't made much progress. I'm definitely interested in adding it. If you would have any interest in contributing to that effort, that would be amazing and I would certainly welcome it. I'd also be happy to do any additional work that's necessary to add the feature so that you could focus on that, such as adding full unit testing to your functionality. In general, the functionality as currently written in the class is not necessarily the most efficient. If you are working with very large amounts of text, you might be best off recreating some of the functions yourself. |
As far as the correct way to use the class, try this:
|
I wrote a crude transliteration that met my needs. Do you want to talk more about it here, or somewhere else? |
Trying this:
Error is this:
Same with:
hebrew_text2 = Hebrew.no_taamim(hebrew_text)
hebrew_text2 = Hebrew.no_taamim(hebrew_text, True, True)
Are you planning on adding a transliteration function? I'm working on that now.
Thanks,
Neal
The text was updated successfully, but these errors were encountered: