Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added payment integration & other fixes #179

Merged
merged 6 commits into from
Jun 28, 2018

Conversation

gopalshimpi
Copy link
Member

@gopalshimpi gopalshimpi commented Jun 22, 2018

Why?

Feature

PayUBiz payment gateway integration(hosted page).

Bug
Fixes for address form( state_id & country_id). Removed static values for state & country ids.

Order success page was throwing error, So unable to display order details.

This change addresses the need by:

Now user will able to process credit and debit card payments & many more using payubiz payment gatewayPayUbiz.

Now user can select dynamic address with respect to state & country id.

[delivers #158423568, #158522773, #158592706]

Story: Payment integration PayUBiz
Story: Address bug fixes
Story: Orders success page Bug fix

@@ -34,7 +34,6 @@
<div class="add-info">{{(address$ | async).address1}}</div>
<div class="add-info">{{(address$ | async).address2}}</div>
<div class="add-info">{{(address$ | async).city}} - {{(address$ | async).zipcode}}</div>
<!--<div class="add-info">Maharashtra</div>-->
<div class="add-info">Mobile: {{(address$ | async).phone}}</div>
</div>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

put this address$ | async in a template variable

@@ -210,7 +210,7 @@ export class CheckoutService {
return this.http
.post(
`api/v1/orders/${
this.orderNumber
this.orderNumber
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

indentations

Copy link
Member

@pkrawat1 pkrawat1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Check comments

@pkrawat1 pkrawat1 merged commit 3a82c61 into develop Jun 28, 2018
@pkrawat1 pkrawat1 deleted the payment-Inegration-158423568 branch June 28, 2018 08:56
pkrawat1 pushed a commit that referenced this pull request Jul 18, 2018
Why?

Feature

PayUBiz payment gateway integration(hosted page).

Bug
Fixes for address form( state_id & country_id). Removed static values for state & country ids.

Order success page was throwing error, So unable to display order details.

This change addresses the need by:

Now user will able to process credit and debit card payments & many more using payubiz payment gatewayPayUbiz.

Now user can select dynamic address with respect to state & country id.

[delivers #158423568, #158522773, #158592706]
pkrawat1 pushed a commit that referenced this pull request Sep 20, 2023
Why?

Feature

PayUBiz payment gateway integration(hosted page).

Bug
Fixes for address form( state_id & country_id). Removed static values for state & country ids.

Order success page was throwing error, So unable to display order details.

This change addresses the need by:

Now user will able to process credit and debit card payments & many more using payubiz payment gatewayPayUbiz.

Now user can select dynamic address with respect to state & country id.

[delivers #158423568, #158522773, #158592706]
@pkrawat1 pkrawat1 restored the payment-Inegration-158423568 branch September 20, 2023 04:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants