Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Angular universal integration #224

Merged
merged 3 commits into from
Aug 6, 2018
Merged

Angular universal integration #224

merged 3 commits into from
Aug 6, 2018

Conversation

pkrawat1
Copy link
Member

@pkrawat1 pkrawat1 commented Aug 1, 2018

Why?

  • In order to support SEO, we should have some provision to allow google crawl the webpages with all the relevant information. This needed a requirement for server side rendered version of this application.

This change addresses the need by:

  • Adds Angular universal support.
  • Updated the code using window, document, local storage with Browser platform checks
  • Updated meta information for main app component.

[delivers #159558419]

Copy link
Member

@gopalshimpi gopalshimpi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@pkrawat1 pkrawat1 merged commit 5de3451 into develop Aug 6, 2018
@pkrawat1 pkrawat1 deleted the angular-universal-init branch August 6, 2018 11:50
pkrawat1 added a commit that referenced this pull request Aug 9, 2018
Why?
In order to support SEO, we should have some provision to allow google crawl the webpages with all the relevant information. This needed a requirement for server side rendered version of this application.
This change addresses the need by:
Adds Angular universal support.
Updated the code using window, document, local storage with Browser platform checks
Updated meta information for main app component.
[delivers #159558419]
pkrawat1 added a commit that referenced this pull request Aug 21, 2018
Why?
In order to support SEO, we should have some provision to allow google crawl the webpages with all the relevant information. This needed a requirement for server side rendered version of this application.
This change addresses the need by:
Adds Angular universal support.
Updated the code using window, document, local storage with Browser platform checks
Updated meta information for main app component.
[delivers #159558419]
pkrawat1 added a commit that referenced this pull request Sep 20, 2023
Why?
In order to support SEO, we should have some provision to allow google crawl the webpages with all the relevant information. This needed a requirement for server side rendered version of this application.
This change addresses the need by:
Adds Angular universal support.
Updated the code using window, document, local storage with Browser platform checks
Updated meta information for main app component.
[delivers #159558419]
pkrawat1 added a commit that referenced this pull request Sep 20, 2023
Why?
In order to support SEO, we should have some provision to allow google crawl the webpages with all the relevant information. This needed a requirement for server side rendered version of this application.
This change addresses the need by:
Adds Angular universal support.
Updated the code using window, document, local storage with Browser platform checks
Updated meta information for main app component.
[delivers #159558419]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants