-
Notifications
You must be signed in to change notification settings - Fork 810
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Angular universal integration #224
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
0ccf2fc
to
a979562
Compare
852cf20
to
b070d24
Compare
gopalshimpi
approved these changes
Aug 6, 2018
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍
pkrawat1
added a commit
that referenced
this pull request
Aug 9, 2018
Why? In order to support SEO, we should have some provision to allow google crawl the webpages with all the relevant information. This needed a requirement for server side rendered version of this application. This change addresses the need by: Adds Angular universal support. Updated the code using window, document, local storage with Browser platform checks Updated meta information for main app component. [delivers #159558419]
pkrawat1
added a commit
that referenced
this pull request
Aug 21, 2018
Why? In order to support SEO, we should have some provision to allow google crawl the webpages with all the relevant information. This needed a requirement for server side rendered version of this application. This change addresses the need by: Adds Angular universal support. Updated the code using window, document, local storage with Browser platform checks Updated meta information for main app component. [delivers #159558419]
pkrawat1
added a commit
that referenced
this pull request
Sep 20, 2023
Why? In order to support SEO, we should have some provision to allow google crawl the webpages with all the relevant information. This needed a requirement for server side rendered version of this application. This change addresses the need by: Adds Angular universal support. Updated the code using window, document, local storage with Browser platform checks Updated meta information for main app component. [delivers #159558419]
pkrawat1
added a commit
that referenced
this pull request
Sep 20, 2023
Why? In order to support SEO, we should have some provision to allow google crawl the webpages with all the relevant information. This needed a requirement for server side rendered version of this application. This change addresses the need by: Adds Angular universal support. Updated the code using window, document, local storage with Browser platform checks Updated meta information for main app component. [delivers #159558419]
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why?
This change addresses the need by:
Browser platform checks
[delivers #159558419]