Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Product list Ui #234

Merged
merged 7 commits into from
Aug 9, 2018
Merged

Product list Ui #234

merged 7 commits into from
Aug 9, 2018

Conversation

jaypal412
Copy link
Contributor

Why?

Feature:

  1. product list UI listing.
  2. Added menu links in category drop-down menu

This change addresses the need by:

The UI of the product list page is changed

[delivers #159542721]

Story

Copy link
Member

@gopalshimpi gopalshimpi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please do as requested.

@@ -34,5 +34,5 @@
(click)="onCloseMobilemenu()">{{taxon.name}}</li>
</ul>
</div>
<div class="need-help">Need help?+91-9176031568</div>
<div class="need-help">Need help?+91-{{contactno}}</div>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add +91 aslo from config. Do not hard code it.

@@ -21,18 +21,18 @@
<ul class="bg-color" *ngIf="menuTaxons">
<li (click)="parrantBack()" class="backbtn">
<i class="fa fa-chevron-left mr-2"></i>Back</li>
<div class="subhead">{{menuTaxons.name}}</div>
<div class="subhead" (click)="onCloseMobilemenu()" [routerLink]="['search']" [queryParams]="{'q[name_cont]': menuTaxons.name, id: menuTaxons.id}" >{{menuTaxons.name}}</div>
Copy link
Member

@gopalshimpi gopalshimpi Aug 7, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why It is added here?

Copy link
Contributor Author

@jaypal412 jaypal412 Aug 8, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

in the mobile view click on the category name the page will show. like on click of dog, dog detail page will be open.

Copy link
Member

@gopalshimpi gopalshimpi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please remove this.

@@ -1,19 +1,19 @@
<div>
xbxcb{{isMobile}}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please remove this.

@pkrawat1 pkrawat1 merged commit 563b629 into develop Aug 9, 2018
@pkrawat1 pkrawat1 deleted the product-list-fixes branch August 9, 2018 09:11
pkrawat1 pushed a commit that referenced this pull request Aug 21, 2018
Why?

Feature:

product list UI listing.
Added menu links in category drop-down menu
This change addresses the need by:

The UI of the product list page is changed

[delivers #159542721]
pkrawat1 pushed a commit that referenced this pull request Sep 20, 2023
Why?

Feature:

product list UI listing.
Added menu links in category drop-down menu
This change addresses the need by:

The UI of the product list page is changed

[delivers #159542721]
pkrawat1 pushed a commit that referenced this pull request Sep 20, 2023
Why?

Feature:

product list UI listing.
Added menu links in category drop-down menu
This change addresses the need by:

The UI of the product list page is changed

[delivers #159542721]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants