-
Notifications
You must be signed in to change notification settings - Fork 810
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
use state transfer for ssr #241
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pkrawat1
added a commit
that referenced
this pull request
Aug 21, 2018
## Why? - During Angular universal application loading, the API requests were running even if the data was already rendered from the server. - The router was flickering on angular universal first page load. - Product detail page shown as blank when data is fetching from api. ## This change addresses the need by: - added state transfer interceptor to check for stored data in state and avoid api calls if data already sent from SSR server - Fixed route resolve issue for product detail - Bug fix for app route flicker on universal boot. Fix shown in this [angular Issue.](angular/angular#15716 (comment))
pkrawat1
added a commit
that referenced
this pull request
Sep 20, 2023
## Why? - During Angular universal application loading, the API requests were running even if the data was already rendered from the server. - The router was flickering on angular universal first page load. - Product detail page shown as blank when data is fetching from api. ## This change addresses the need by: - added state transfer interceptor to check for stored data in state and avoid api calls if data already sent from SSR server - Fixed route resolve issue for product detail - Bug fix for app route flicker on universal boot. Fix shown in this [angular Issue.](angular/angular#15716 (comment))
pkrawat1
added a commit
that referenced
this pull request
Sep 20, 2023
## Why? - During Angular universal application loading, the API requests were running even if the data was already rendered from the server. - The router was flickering on angular universal first page load. - Product detail page shown as blank when data is fetching from api. ## This change addresses the need by: - added state transfer interceptor to check for stored data in state and avoid api calls if data already sent from SSR server - Fixed route resolve issue for product detail - Bug fix for app route flicker on universal boot. Fix shown in this [angular Issue.](angular/angular#15716 (comment))
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why?
This change addresses the need by: