Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use state transfer for ssr #241

Merged
merged 9 commits into from
Aug 21, 2018
Merged

Conversation

pkrawat1
Copy link
Member

@pkrawat1 pkrawat1 commented Aug 16, 2018

Why?

  • During Angular universal application loading, the API requests were running even if the data was already rendered from the server.
  • The router was flickering on angular universal first page load.
  • Product detail page shown as blank when data is fetching from api.

This change addresses the need by:

  • added state transfer interceptor to check for stored data in state and avoid api calls if data already sent from SSR server
  • Fixed route resolve issue for product detail
  • Bug fix for app route flicker on universal boot. Fix shown in this angular Issue.

@pkrawat1 pkrawat1 changed the base branch from master to develop August 16, 2018 18:07
@pkrawat1 pkrawat1 changed the base branch from develop to snitch August 16, 2018 18:07
@pkrawat1 pkrawat1 changed the base branch from snitch to develop August 16, 2018 18:08
@pkrawat1 pkrawat1 merged commit 154e379 into develop Aug 21, 2018
@pkrawat1 pkrawat1 deleted the bug/use-state-transfer-for-ssr branch August 21, 2018 12:37
pkrawat1 added a commit that referenced this pull request Aug 21, 2018
## Why?

- During Angular universal application loading, the API requests were running even if the data was already rendered from the server.
- The router was flickering on angular universal first page load.
- Product detail page shown as blank when data is fetching from api.

## This change addresses the need by:

- added state transfer interceptor to check for stored data in state and avoid api calls if data already sent from SSR server
- Fixed route resolve issue for product detail
- Bug fix for app route flicker on universal boot. Fix shown in this [angular Issue.](angular/angular#15716 (comment))
pkrawat1 added a commit that referenced this pull request Sep 20, 2023
## Why?

- During Angular universal application loading, the API requests were running even if the data was already rendered from the server.
- The router was flickering on angular universal first page load.
- Product detail page shown as blank when data is fetching from api.

## This change addresses the need by:

- added state transfer interceptor to check for stored data in state and avoid api calls if data already sent from SSR server
- Fixed route resolve issue for product detail
- Bug fix for app route flicker on universal boot. Fix shown in this [angular Issue.](angular/angular#15716 (comment))
pkrawat1 added a commit that referenced this pull request Sep 20, 2023
## Why?

- During Angular universal application loading, the API requests were running even if the data was already rendered from the server.
- The router was flickering on angular universal first page load.
- Product detail page shown as blank when data is fetching from api.

## This change addresses the need by:

- added state transfer interceptor to check for stored data in state and avoid api calls if data already sent from SSR server
- Fixed route resolve issue for product detail
- Bug fix for app route flicker on universal boot. Fix shown in this [angular Issue.](angular/angular#15716 (comment))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant