[SagePay]Implemented authorize function for sagepay #131

Anwar0902 · 2018-03-20T16:13:48Z

In this we generated merchant_session_key and card_identifier to
complete the authorization with all details provided in 'opts' option

oyeb · 2018-03-20T17:01:57Z

lib/gringotts/gateways/sagepay.ex

@@ -0,0 +1,362 @@
+defmodule Gringotts.Gateways.Sagepay do


CamelCase module, also their brand is written in that case too: SagePay.

oyeb · 2018-03-20T17:02:54Z

lib/gringotts/gateways/sagepay.ex

+
+
+
+  ## Instructions!


This was an instruction, read once then remove. We cannot merge it in this state can we?

oyeb · 2018-03-20T17:06:55Z

lib/gringotts/gateways/sagepay.ex

+  # and with merchant_session_key, card_identifiier ,shipping address of a
+  # customer, and other details and converting the map into keyword list
+
+  defp card_details(amount, merchant_key, card_key, opts) do


This function does a lot more than just build card details. Would be better to split it into at least card_details and other_details.

oyeb · 2018-03-20T17:08:15Z

lib/gringotts/gateways/sagepay.ex

+        },
+        "vendorTxCode" => opts[:vendorTxCode],
+        "amount" => amount,
+        "currency" => opts[:currency],


The currency is not passed via opts! amount is of type Money.t (a struct, defined in the Money library), and it contains the currency.
Read #62 for more info.

oyeb · 2018-03-20T17:08:55Z

lib/gringotts/gateways/sagepay.ex

+        "description" => opts[:description],
+        "customerFirstName" => opts[:customerFirstName],
+        "customerLastName" => opts[:customerLastName],
+        "billingAddress" => %{


This should have been fetched from an Address struct, not a simple map.

oyeb · 2018-03-20T17:12:40Z

lib/gringotts/gateways/sagepay.ex

+  # Parses sagepay's response and returns a `Gringotts.Response` struct
+  # in a `:ok`, `:error` tuple.
+
+  defp format_response(response) do


This function does not return a Response struct, though @spec of authorize suggests that it would return a Response tuple.

Please use one of the respond clauses from below.

oyeb · 2018-03-20T17:13:28Z

lib/gringotts/gateways/sagepay.ex

+      {"Content-type", "application/json"}
+    ]
+
+    body = commit(:post, "transactions", card_params, card_header)


This binding serves no purpose.

oyeb · 2018-03-20T17:15:02Z

lib/gringotts/gateways/sagepay.ex

+  # Function generate_mkey generate a merchant_session_key that will exist only for 400 seconds
+  # and for 3 wrong card identifiers
+
+  defp generate_mkey(opts) do


IMO genereate_merchant_key is a better name here.

oyeb

Good work on the docs! ❤️

oyeb · 2018-03-22T08:06:27Z

lib/gringotts/gateways/sagepay.ex


  ## Scope of this module

-  > It's unlikely that your first iteration will support all features of the
-  > gateway, so list down those items that are missing.
+  * SagePay does not process money in cents, and the `amount` is converted to integer.


What is "rendered" in the authorize request if I wish to make a payment for $3.14, "314" or "3.14"?

oyeb · 2018-03-22T08:07:26Z

lib/gringotts/gateways/sagepay.ex

-  > It's unlikely that your first iteration will support all features of the
-  > gateway, so list down those items that are missing.
+  * SagePay does not process money in cents, and the `amount` is converted to integer.
+  * SagePay supports payments from various cards and banks.

  ## Supported currencies and countries


Supported currencies

Could you also add a link to the docs from where you found this info?

oyeb · 2018-03-22T08:09:52Z

lib/gringotts/gateways/sagepay.ex

-  [home]: https://www.sagepay.co.uk/
-  [example]: https://github.com/aviabird/gringotts_example
+  [iex-docs]: https://hexdocs.pm/iex/IEx.html#module-the-iex-exs-file
+  [sagepay.iex.exs]: https://github.com/Anwar0902/graph/blob/master/sagepay.iex.exs


❤️ 💛 💜 Thanks for making a .iex.exs! There are many ways of sharing it with others, and I highly recommend making a gist instead of a file in a repo.

oyeb · 2018-03-22T08:11:18Z

lib/gringotts/gateways/sagepay.ex


  ## Note

-  > If there's anything noteworthy about this operation, it comes here.
+  * The merchantSessionKey expires after 400 seconds and can only be used to create one successful card identifier. 
+  * It will also expire and be removed after 3 failed attempts to create a card identifier.


Who will expire? the session key or the transaction ID?

It'll be great if you add a link to SagePay docs for this!

oyeb · 2018-03-22T08:15:44Z

lib/gringotts/gateways/sagepay.ex

-      })
+      },
+      "vendorTxCode" => opts[:vendorTxCode],
+      "amount" => Kernel.trunc(String.to_float(value)),


You perhaps want to use Money.to_integer/1. It'll be easier to figure this out if you look at activemerchant implementation of SagePay.

oyeb · 2018-03-22T08:17:24Z

lib/gringotts/gateways/sagepay.ex

@@ -111,39 +103,70 @@ defmodule Gringotts.Gateways.Sagepay do

  alias Gringotts.{Money, CreditCard, Response}
  @url "https://pi-test.sagepay.com/api/v1/"
+
+  # SagePay supports payment only by Merchant Authorization Id and Merchant name


Please move this very important comment into the @doc.

RajeetKaushal · 2018-03-22T09:52:41Z

lib/gringotts/gateways/sagepay.ex

+  ## The `opts` argument
+
+  Most `Gringotts` API calls accept an optional `keyword` list `opts` to supply
+  [optional arguments][extra-arg-docs] for transactions with the MONEI


oyeb

Please remove implementation of capture/3
Make lot of use of backticks in docs, especially for argument names, keys of a keyword list, atoms.

oyeb · 2018-03-27T11:58:24Z

lib/gringotts/gateways/sagepay.ex

@@ -170,22 +168,43 @@ defmodule Gringotts.Gateways.SagePay do
  end

  @doc """
-  Captures a pre-authorized `amount`.
+  Captures a pre-authorized amount.


The backticks were rightly placed. Why did you remove them?

oyeb · 2018-03-27T11:59:14Z

lib/gringotts/gateways/sagepay.ex


  ## Note

-  > If there's anything noteworthy about this operation, it comes here.
-  > For example, does the gateway support partial, multiple captures?
+  * Deferred transactions are not sent to the bank for completion until you capture them using the capture instruction. 


What's a deferred transaction?

You can release...
what's a release?

oyeb · 2018-03-27T12:03:30Z

lib/gringotts/gateways/sagepay.ex


  ## Example

-  > A barebones example using the bindings you've suggested in the `moduledoc`.
+  The following example shows how one would (partially) capture a previously
+  authorized a payment worth 100 by referencing the obtained authorization id.


100 pounds or 100 £, units are important (this is not 100 pennies, for example).

oyeb · 2018-03-27T12:04:55Z

lib/gringotts/gateways/sagepay.ex

@@ -313,12 +340,15 @@ defmodule Gringotts.Gateways.SagePay do
      {"Content-type", "application/json"}
    ]

-    {:ok, merchant_key} = commit(:post, "merchant-session-keys", vender_name, merchant_header)
+    {:ok, merchant_key} =
+      commit_for_key(:post, "merchant-session-keys", vender_name, merchant_header)


Typo: vendor_name

oyeb · 2018-03-27T12:33:17Z

lib/gringotts/gateways/sagepay.ex

+    |> respond
+  end
+
+  defp commit_for_key(:post, endpoint, params, opts) do


Since there is only 1 call site for this function, we can move the logic there.

Since the logic of commit_for_key is totally different from the commit. So, I think we can't move.

My bad! I didn't realise that commit_for_key is called from 2 functions. However, format_response can be moved inside commit_for_key.

oyeb · 2018-03-27T12:36:14Z

lib/gringotts/gateways/sagepay.ex

+  |  ---------------         |
+  |  [`merchant_id`]         |
+  |  [`vendor`]              |
+  |  [`vendorTxcode`]        |  


Please follow the elixir style for these atoms (snake_case).

Why are these surrounded by []?

If there's only going to be billingAddress (and no other addresses), then let's call it address instead.

oyeb · 2018-03-27T12:45:08Z

lib/gringotts/gateways/sagepay.ex

+       id: body["transactionId"],
+       status_code: 201,
+       message: body["statusDetail"],
+       raw: body |> Poison.encode!()


You were forced to do this just because you didn't use a different var name on L426 😝

oyeb

Please go through your docs and add backticks wherever applicable:

argument name
atom, especially when it is a key in opts

oyeb · 2018-03-29T09:12:00Z

lib/gringotts/gateways/sagepay.ex

+
+  * The merchant_session_key expires after 400 seconds and can only be used to create one successful card identifier. 
+  * It will also expire and be removed after 3 failed attempts to create a card identifier.
+  * vendor_tx_code Code in opts should always be unique.


Use bacticks pls, you've missed them in some more places

oyeb · 2018-03-29T09:13:05Z

lib/gringotts/gateways/sagepay.ex

+    a_url = @url <> endpoint
+
+    response = HTTPoison.post(a_url, params, opts)
+    format_response(response)


Move the logic in format_response here, as it is called only from here.

oyeb · 2018-03-29T09:14:14Z

lib/gringotts/gateways/sagepay.ex

+          "save" => false
+        }
+      },
+      "vendorTxCode" => opts[:vendorTxCode],


Though you've updated the moduledoc with snake_case atoms, you haven't updated the code, this should have been opts[:vendor_tx_code]

oyeb · 2018-03-29T09:16:56Z

test/integration/gateways/sagepay_test.exs

+
+  @moduletag :integration
+
+  setup_all do


This block is not required, the application config is fetched by Gringotts which is not used here.

oyeb · 2018-03-29T09:20:44Z

lib/gringotts/gateways/sagepay.ex

+      "description" => opts[:description],
+      "customerFirstName" => opts[:customerFirstName],
+      "customerLastName" => opts[:customerLastName],
+      "billingAddress" => %{


Your docs should say that a billing_address, if provided, should be an Address struct.

oyeb

Please make sure your branch is up-to-date with dev:
Use git rebase:

git checkout dev
git pull
git checkout sagepay
git rebase -i dev
If git rebase turns up a lot of conflicts, we will allow a shortcut just this one time, instead of last step (above) do:
git merge dev

After doing this, please remove all compile time warnings in both dev and test env by:

dev environment:

mix clean gringotts
mix compile, and look for warnings from sagepay

test environment:

MIX_ENV=test mix clean gringotts
MIX_ENV=test mix compile

Also run credo and fix all sagepay related warnings:
mix credo --strict OR mix credo --strict --format=oneline | grep sagepay

oyeb · 2018-03-30T05:57:40Z

lib/gringotts/gateways/sagepay.ex


  ## Example

  The following example shows how one would (pre) authorize a payment of 42£ on
  a sample `card`.

      iex> amount = Money.new(42, :GBP)
-      iex> address = %{ address1: "407 St. John Street", city: "London", postalCode: "EC1V 4AB", country: "GB"} 
+      iex> address = %{ street1: "407 St.", street2: "John Street", city: "London", postalCode: "EC1V 4AB", country: "GB"} 


address = %Address{street1: ...}

oyeb · 2018-03-30T05:58:43Z

test/integration/gateways/sagepay_test.exs

-      opts = @opts ++ [vendorTxCode: "demotransaction-" <> random_code]
-      assert {:ok, response} = SagePay.authorize(@amount, @card, opts)
+    test "successful response with valid params", %{opts: opts} do
+      use_cassette "SagePay/authorize_with_valid_params" do


use_cassette "sagepay/*" do

codecov-io · 2018-03-31T12:03:42Z

Codecov Report

Merging #131 into dev will decrease coverage by 6.6%.
The diff coverage is 2.77%.

@@            Coverage Diff             @@
##              dev     #131      +/-   ##
==========================================
- Coverage   77.33%   70.73%   -6.61%     
==========================================
  Files          14       15       +1     
  Lines         375      410      +35     
==========================================
  Hits          290      290              
- Misses         85      120      +35

Impacted Files	Coverage Δ
lib/gringotts/response.ex	`100% <ø> (ø)`	⬆️
lib/gringotts/gateways/paymill.ex	`100% <ø> (ø)`	⬆️
lib/gringotts/gateways/sagepay.ex	`0% <0%> (ø)`
lib/gringotts/gateways/monei.ex	`97.95% <100%> (ø)`	⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7e7a5d3...253847a. Read the comment docs.

oyeb

Please take a look at #150 and make the necessary correction.

oyeb · 2018-04-09T05:34:21Z

lib/gringotts/gateways/sagepay.ex

+      iex> amount = Money.new(42, :GBP)
+      iex> address = %Address{ street1: "407 St.", street2: "John Street", city: "London", postalCode: "EC1V 4AB", country: "GB"} 
+      iex> card = %Gringotts.CreditCard{number: "4929000005559",month: 3,year: 20,first_name: "SAM",last_name: "JONES",verification_code: "123",brand: "VISA"}
+      iex> opts = [


Please remove the :config key from the example, this will be automatically added by Gringotts.get_and_validate_config/1

oyeb · 2018-04-09T05:34:39Z

lib/gringotts/gateways/sagepay.ex

+
+  ## Supported currencies and countries
+
+      :AUD, :CAD, :CHF, :CYP, :DKK, :EUR, :GBP, :HKD, :INR, :JPY, 


Please remove the colons.

oyeb · 2018-04-09T05:35:24Z

lib/gringotts/gateways/sagepay.ex

+    merchant_key = generate_merchant_key(opts)
+
+    card = card_params(card)
+    card_identifiier = generate_card_identifier(card, merchant_key)


typo: card_identifier

oyeb · 2018-04-09T05:42:05Z

lib/gringotts/gateways/sagepay.ex

+
+    case response do
+      {:ok, %HTTPoison.Response{body: body}} -> {:ok, body |> Poison.decode!()}
+      _ -> %{"error" => "something went wrong, please try again later"}


This error message is never propagated to the Response. If the session key/card identifier cannot be generated, a call to authorize should fail "fast" (we should not attempt to do any further computation).

oyeb · 2018-04-09T05:53:48Z

lib/gringotts/gateways/sagepay.ex

+  # Function `generate_merchant_key` generate a `merchant_session_key` that will exist only for 400
+  # seconds and for 3 wrong `card_identifiers`.
+
+  defp generate_merchant_key(opts) do


The caller should be able to pass in a merchant key in opts, and in such a case we should simply use it.

This is not possible because its mandatory to create merchant key every time.

Typically, a capture follows immediately after a successful authorization - hence the capture can use the same key (as the key is invalidated only after 400 seconds).
We can get to this when we implement capture.

oyeb · 2018-04-09T05:55:42Z

lib/gringotts/gateways/sagepay.ex

+  |  `vendor`              |  Name of the merchant.                                                      |
+  |  `vendor_tx_code`      |  vendor_tx_code is a unique code for every transaction in SagePay.          |
+  |  `transaction_type`    |  SagePay allows four transactions type:- Deferred, Payment, Repeat, Refund. |
+  |  `customer_first_name` |  First name of a customer.                                                  |


This can be shortened to first_name and last_name resp.

oyeb · 2018-04-09T05:58:38Z

lib/gringotts/gateways/sagepay.ex

+      "customerLastName" => opts[:customer_last_name],
+      "billingAddress" => %{
+        "address1" => full_address,
+        "city" => opts[:billing_address].city,


The moduledoc was updated to simply address (L38), but not in code.

oyeb · 2018-04-09T06:01:50Z

lib/gringotts/gateways/sagepay.ex

+  a sample `card`.
+
+      iex> amount = Money.new(42, :GBP)
+      iex> address = %Address{ street1: "407 St.", street2: "John Street", city: "London", postalCode: "EC1V 4AB", country: "GB"} 


typo: postalCode is not defined in Address.t

oyeb · 2018-04-09T06:30:22Z

lib/gringotts/gateways/sagepay.ex

+  [gs]: file:///home/anwar/gringotts/doc/Gringotts.Gateways.SagePay.html#
+  [example]: https://github.com/aviabird/gringotts_example
+  [iex-docs]: https://hexdocs.pm/iex/IEx.html#module-the-iex-exs-file
+  [sagepay.iex.exs]: https://github.com/Anwar0902/graph/blob/master/sagepay.iex.exs


Please move this to a GitHub gist.

oyeb · 2018-04-09T07:10:50Z

lib/gringotts/gateways/sagepay.ex

+                  customer_last_name: "Jones",
+                  billing_address: address
+            ]
+      iex> {:ok, auth_result} = Gringotts.authorize(Gringotts.Gateways.SagePay, amount, card, opts)


This is the response I received:

iex(14)> Poison.decode! auth_result.raw %{ "3DSecure" => %{"status" => "CardNotEnrolled"}, "amount" => %{"saleAmount" => 42, "surchargeAmount" => 0, "totalAmount" => 42}, "avsCvcCheck" => %{ "address" => "NotProvided", "postalCode" => "NotProvided", "securityCode" => "NotProvided", "status" => "NotChecked" }, "bankAuthorisationCode" => "999777", "bankResponseCode" => "00", "currency" => "GBP", "paymentMethod" => %{ "card" => %{ "cardIdentifier" => "3248A1A6-5A44-470B-BC92-83536C486971", "cardType" => "Visa", "expiryDate" => "0320", "lastFourDigits" => "5559", "reusable" => false } }, "retrievalReference" => 17717235, "status" => "Ok", "statusCode" => "0000", "statusDetail" => "The Authorisation was Successful.", "transactionId" => "EF99769B-EFE0-68EA-17B8-F38F6476B511", "transactionType" => "Deferred" }

The example supplies the (billing) address to SagePay but the avsCvcCheck indicates otherwise. Please get this to work. Even if SagePay does not do the AVS check, you should format this into Response.fraud_review field.

The paymentMethod indicates that this card is NOT reusable. Surely there must be some way to generate a reusable card_identifier?

Please make use of Response.token field to return the card_identifier to the caller.

For point 3:-for the transaction a unique merchant key pair with a unique card identifier.We can't use the card identifier for future transaction.So there is no need to store it.

curl https://pi-test.sagepay.com/api/v1/transactions \ -H "Authorization: Basic aEpZeHN3N0hMYmo0MGNCOHVkRVM4Q0RSRkxodUo4RzU0TzZyRHBVWHZFNmhZRHJyaWE6bzJpSFNyRnliWU1acG1XT1FNdWhzWFA1MlY0ZkJ0cHVTRHNocktEU1dzQlkxT2lONmh3ZDlLYjEyejRqNVVzNXU=" \ -H "Content-type: application/json" \ -X POST \ -d '{ "transactionType": "Payment", "paymentMethod": { "card": { "merchantSessionKey": "<merchant-session-key>", "cardIdentifier": "<card-identifier>", "save": false } }, "vendorTxCode": "demotransaction-<unique-suffix>", "amount": 10000, "currency": "GBP", "description": "Demo Payment", "apply3DSecure": "UseMSPSetting", "customerFirstName": "Sam", "customerLastName": "Jones", "billingAddress": { "address1": "407 St. John Street", "city": "London", "postalCode": "EC1V 4AB", "country": "GB" }, "entryMethod": "Ecommerce" }'

When we used this on postman after creating merchant key and card identifier the response was

{ "statusCode": "2007", "statusDetail": "Please redirect your customer to the ACSURL to complete the 3DS Transaction", "transactionId": "D6146D7B-033E-9E2A-C52C-87A7D3E107EA", "acsUrl": "https://test.sagepay.com/mpitools/accesscontroler?action=pareq", "paReq": "eJxVUsluwjAQvfcrIj4gXrJA0WAE5dAIaKOCVKk3y7FKVLJgJ03o19fOUoovnvc8ejPzxrBss7PzLZVOi3wxIS6eLNkDHE9Kys1BilpJBnupNf+UTposJhSTgPrBo4+9aUiIF4Q+mTCIV2/ywmAQYkbHJYBGaBSUOPG8YsDFZR29MN8PvTAANEDIpIo2jBLcn/4G1NOQ80yyg2kh5teNzIqVEEWdV4C6B+iAurIZDQGNAGp1Zk3TuLb1kl9dUbj1FyBLA7o1FNc20kamTRN2rFpSbn8+NEqa3fakd++4vkTJ61o3C0A2AxJeSWZsmGGf+g55nFM896aAOh54Zusz0vc/IChtkdXd038KjM9K5mIcYUQg27LIpcmggP5iSKQWnR2O8cPZx5EpbilAt2Genq3XojL2EWtzF1m91HhDMfY6QQsA2Vw0bBANyzbR3Sf4BaPUtJU=", "status": "3DAuth" }

so this asked to go to 3D secure site and to avs-check than asked not to do 3D secure procedure so we left that part .

in transaction body we have not used "apply3DSecure": "UseMSPSetting" we have done that for without 3D secure

We allow the gateway to return multiple tokens, as a `keyword`.

renamed zip_code -> postal_code

In this we generated merchant_session_key and card_identifier to complete the authorization with all details provided in 'opts' option

change card configuration as per the Gringotts.CreditCard change amount structure as per the Gringotts.Money

Implement respond function for response generation as per Gringotts.Response Struct for billing address as per Gringotts.Address Improvement in Documentation

Implemented capture function to coplete the transaction Generation of docs for capture function

Generation og test cases Correction in respond function

Improvement in Integration test cases for SagePay

Improvement in docs changed billing_address to address Changed the naming convention of keys

remove the decode code for body in sagepay

Used backtick for :atoms and keys in opts Changed camel case for parameters to snake case Merged commit_for_keys and format_response into format_response

Used use_cassette for test cases

use_cassette for test case is written

Correct the name sagepay in use_cassette

removed extra spaces and changes in HTTPoision

unwanted variables and functions removed.

Add transaction type payment and deffered Change opts structure

Remove the colon from the currency

* AVS and CVC checks are enforced * `transaction_type` is no longer fetched from `opts` * The session key and card ID are both returned under `tokens` field * Improved test setup and case

oyeb · 2018-06-07T13:02:24Z

Work is done. This is slated for v1.3.x
Thanks @Anwar0902 and @KillerBeer 🎉

oyeb requested changes Mar 20, 2018

View reviewed changes

oyeb requested changes Mar 22, 2018

View reviewed changes

RajeetKaushal reviewed Mar 22, 2018

View reviewed changes

KillerBeer force-pushed the sagepay branch from 5d8976a to a711e7e Compare March 22, 2018 10:52

Anwar0902 force-pushed the sagepay branch from a711e7e to 31b16cc Compare March 22, 2018 11:04

oyeb requested changes Mar 27, 2018

View reviewed changes

Anwar0902 changed the title ~~Implemented authorize function for sagepay~~ [SagePay]Implemented authorize function for sagepay Mar 29, 2018

oyeb requested changes Mar 29, 2018

View reviewed changes

oyeb reviewed Mar 29, 2018

View reviewed changes

oyeb requested changes Mar 30, 2018

View reviewed changes

Anwar0902 force-pushed the sagepay branch from 8b548c0 to baa0559 Compare March 31, 2018 12:01

oyeb requested changes Apr 9, 2018

View reviewed changes

ashish173 force-pushed the dev branch 2 times, most recently from 207537c to b1b7891 Compare April 22, 2018 12:30

oyeb force-pushed the dev branch from 2fca824 to 7e7a5d3 Compare June 6, 2018 16:40

oyeb force-pushed the sagepay branch from 5d4ad79 to 64f2412 Compare June 6, 2018 17:28

oyeb and others added 12 commits June 7, 2018 14:18

Expand token field in Response

a17ee91

We allow the gateway to return multiple tokens, as a `keyword`.

Fix MONEI and Paymill's use of :token

45dd98b

Fix avs_result schema

ff11a79

renamed zip_code -> postal_code

Implemented authorize function for sagepay

98e0181

In this we generated merchant_session_key and card_identifier to complete the authorization with all details provided in 'opts' option

Changes in docs and authorize function

2192462

change card configuration as per the Gringotts.CreditCard change amount structure as per the Gringotts.Money

Implementation of Respond function and changes in Optional parameters

02e15df

Implement respond function for response generation as per Gringotts.Response Struct for billing address as per Gringotts.Address Improvement in Documentation

Implementation of capture function

c41254c

Implemented capture function to coplete the transaction Generation of docs for capture function

Implementation of Integration test cases for SagePay

67a38e4

Generation og test cases Correction in respond function

Improvement in test cases

451a06f

Improvement in Integration test cases for SagePay

Improvement in docs for SagePay

097f583

Improvement in docs changed billing_address to address Changed the naming convention of keys

Changes in respond function of SagePay

5eb563d

remove the decode code for body in sagepay

Improvement in docs for SagePay

376eb5f

Used backtick for :atoms and keys in opts Changed camel case for parameters to snake case Merged commit_for_keys and format_response into format_response

Anwar0902 and others added 8 commits June 7, 2018 18:14

Improvement in test cases for SagePay

3cb01eb

Used use_cassette for test cases

Improvement in test cases for authorize

0e9f3fe

use_cassette for test case is written

Improvement in test case for authorize function

05d3152

Correct the name sagepay in use_cassette

Change in Documentation

ae1bbc6

removed extra spaces and changes in HTTPoision

Changes in Test Cases

f737fe2

unwanted variables and functions removed.

Changed the test cases for authorize function

e408aa5

Add transaction type payment and deffered Change opts structure

Changes in docs

8471e84

Remove the colon from the currency

Refactor sagepay, add avs/cvc, tokens field

253847a

* AVS and CVC checks are enforced * `transaction_type` is no longer fetched from `opts` * The session key and card ID are both returned under `tokens` field * Improved test setup and case

oyeb force-pushed the sagepay branch from 64f2412 to 253847a Compare June 7, 2018 12:58

oyeb closed this Jun 7, 2018


		## Supported currencies and countries

		:AUD, :CAD, :CHF, :CYP, :DKK, :EUR, :GBP, :HKD, :INR, :JPY,

[SagePay]Implemented authorize function for sagepay #131

[SagePay]Implemented authorize function for sagepay #131

Conversation

Anwar0902 commented Mar 20, 2018

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

oyeb left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Supported currencies

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

oyeb left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

oyeb Mar 27, 2018 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

oyeb left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

oyeb left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

codecov-io commented Mar 31, 2018 • edited Loading

Codecov Report

oyeb left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

KillerBeer Apr 24, 2018 • edited by oyeb Loading

Choose a reason for hiding this comment

oyeb commented Jun 7, 2018

oyeb Mar 27, 2018 •

edited

Loading

codecov-io commented Mar 31, 2018 •

edited

Loading

KillerBeer Apr 24, 2018 •

edited by oyeb

Loading