Money Integration with Authorize.Net #82
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oyeb
reviewed
Jan 16, 2018
test/gateways/authorize_net_test.exs
Outdated
| @@ -23,8 +23,7 @@ defmodule Gringotts.Gateways.AuthorizeNetTest do | |||
| verification_code: 123 | |||
| } | |||
|
|
|||
| @amount 20 | |||
| @bad_amount "a" | |||
| @amount %{value: Decimal.new(20.0), currency: 'USD'} | |||
There was a problem hiding this comment.
Use double quotes for strings: "USD".
arjun289
force-pushed
the
anet-currency
branch
from
9af55bb
to
dd29a00
Compare
arjun289
force-pushed
the
anet-currency
branch
from
dd29a00
to
3268c28
Compare
arjun289
force-pushed
the
anet-currency
branch
from
3268c28
to
47a206b
Compare
Used Gringotts.Money to check for money params. Added doc for Authorize Net currency support. Modified the test amount value and some tests to accomodate Gringotts.Money integration. Also modified add_amount function to check the amount for nil.
arjun289
force-pushed
the
anet-currency
branch
from
47a206b
to
d118c48
Compare
pkrawat1
pushed a commit
that referenced
this pull request
Jan 25, 2018
Used Gringotts.Money for Authorize Net currency support.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Used Gringotts.Money to check for money params.
Added doc for Authorize Net currency support.
Currently, I have to convert
Decimalto a lossyfloatbecause a string amount is not accepted by the Authorize.Net lib. Will raise an issue with Authorize.Net regarding this.