sort out interfaces #230
Merged
sort out interfaces #230
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #230 +/- ##
==========================================
+ Coverage 86.14% 86.20% +0.05%
==========================================
Files 12 12
Lines 1689 1696 +7
==========================================
+ Hits 1455 1462 +7
Misses 234 234
Continue to review full report at Codecov.
|
aviatesk
force-pushed
the
avi/interface
branch
2 times, most recently
from
0f005fd
to
5747f7b
Compare
The current infrastructure is messy. Let's sort it out and clean it up. - remove unnecessary `report!` indirection, rename to `add_new_report!`, which requires explicit report constructions - remove unnecessary `report_pass!` indirection, require explicit `ReportPass` constructions - update documents
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current infrastructure is messy. Let's sort it out and clean it up.
report!indirection, rename toadd_new_report!,which requires explicit report constructions
report_pass!indirection, require explicitReportPassconstructions