-
Notifications
You must be signed in to change notification settings - Fork 29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
report errors within any compileable frames #288
Conversation
Previously, JET ignored possible errors within any abstract frames (i.e. those do not satisfy `isdispatchtuple(frame.linfo.specTypes)`), but abstract call can be compiled and executed if the `@nospecialize` annotation is used. This change respects `@nospecialize` annotations, and make the default passes report errors within any "compileable" frames.
03083d6
to
00fa5be
Compare
JET Benchmark ResultJudge resultBenchmark Report for /home/runner/work/JET.jl/JET.jlJob Properties
ResultsA ratio greater than
Benchmark Group ListHere's a list of all the benchmark groups executed by this job:
Julia versioninfoTarget
Baseline
Target resultBenchmark Report for /home/runner/work/JET.jl/JET.jlJob Properties
ResultsBelow is a table of this job's results, obtained by running the benchmarks.
Benchmark Group ListHere's a list of all the benchmark groups executed by this job:
Julia versioninfo
Baseline resultBenchmark Report for /home/runner/work/JET.jl/JET.jlJob Properties
ResultsBelow is a table of this job's results, obtained by running the benchmarks.
Benchmark Group ListHere's a list of all the benchmark groups executed by this job:
Julia versioninfo
Runtime information
Architecture: x86_64
JET Benchmark ResultJudge resultBenchmark Report for /home/runner/work/JET.jl/JET.jlJob Properties
ResultsA ratio greater than
Benchmark Group ListHere's a list of all the benchmark groups executed by this job:
Julia versioninfoTarget
Baseline
Target resultBenchmark Report for /home/runner/work/JET.jl/JET.jlJob Properties
ResultsBelow is a table of this job's results, obtained by running the benchmarks.
Benchmark Group ListHere's a list of all the benchmark groups executed by this job:
Julia versioninfo
Baseline resultBenchmark Report for /home/runner/work/JET.jl/JET.jlJob Properties
ResultsBelow is a table of this job's results, obtained by running the benchmarks.
Benchmark Group ListHere's a list of all the benchmark groups executed by this job:
Julia versioninfo
Runtime information
Architecture: x86_64
|
Codecov Report
@@ Coverage Diff @@
## master #288 +/- ##
==========================================
+ Coverage 89.09% 89.20% +0.10%
==========================================
Files 10 10
Lines 2220 2241 +21
==========================================
+ Hits 1978 1999 +21
Misses 242 242
Continue to review full report at Codecov.
|
Previously, JET ignored possible errors within any abstract frames
(i.e. those do not satisfy
isdispatchtuple(frame.linfo.specTypes)
),but abstract call can be compiled and executed if the
@nospecialize
annotation is used.
This change respects
@nospecialize
annotations, and make the defaultpasses report errors within any "compileable" frames.
And then our self checks also revealed we're actually doing excessive specializations in some places.
The second commit eliminates them.