adds ignored_modules configuration
#372
Conversation
aviatesk
force-pushed
the
avi/354
branch
2 times, most recently
from
1a7cb8c
to
ac2fadc
Compare
Codecov Report
@@ Coverage Diff @@
## master #372 +/- ##
==========================================
- Coverage 90.11% 90.02% -0.09%
==========================================
Files 11 11
Lines 2619 2636 +17
==========================================
+ Hits 2360 2373 +13
- Misses 259 263 +4
Continue to review full report at Codecov.
|
JET Benchmark ResultJudge resultBenchmark Report for /home/runner/work/JET.jl/JET.jlJob Properties
ResultsA ratio greater than
Benchmark Group ListHere's a list of all the benchmark groups executed by this job:
Julia versioninfoTargetBaselineTarget resultBenchmark Report for /home/runner/work/JET.jl/JET.jlJob Properties
ResultsBelow is a table of this job's results, obtained by running the benchmarks.
Benchmark Group ListHere's a list of all the benchmark groups executed by this job:
Julia versioninfoBaseline resultBenchmark Report for /home/runner/work/JET.jl/JET.jlJob Properties
ResultsBelow is a table of this job's results, obtained by running the benchmarks.
Benchmark Group ListHere's a list of all the benchmark groups executed by this job:
Julia versioninfoRuntime information
Architecture: x86_64
JET Benchmark ResultJudge resultBenchmark Report for /home/runner/work/JET.jl/JET.jlJob Properties
ResultsA ratio greater than
Benchmark Group ListHere's a list of all the benchmark groups executed by this job:
Julia versioninfoTargetBaselineTarget resultBenchmark Report for /home/runner/work/JET.jl/JET.jlJob Properties
ResultsBelow is a table of this job's results, obtained by running the benchmarks.
Benchmark Group ListHere's a list of all the benchmark groups executed by this job:
Julia versioninfoBaseline resultBenchmark Report for /home/runner/work/JET.jl/JET.jlJob Properties
ResultsBelow is a table of this job's results, obtained by running the benchmarks.
Benchmark Group ListHere's a list of all the benchmark groups executed by this job:
Julia versioninfoRuntime information
Architecture: x86_64
JET Benchmark ResultJudge resultBenchmark Report for /home/runner/work/JET.jl/JET.jlJob Properties
ResultsA ratio greater than
Benchmark Group ListHere's a list of all the benchmark groups executed by this job:
Julia versioninfoTargetBaselineTarget resultBenchmark Report for /home/runner/work/JET.jl/JET.jlJob Properties
ResultsBelow is a table of this job's results, obtained by running the benchmarks.
Benchmark Group ListHere's a list of all the benchmark groups executed by this job:
Julia versioninfoBaseline resultBenchmark Report for /home/runner/work/JET.jl/JET.jlJob Properties
ResultsBelow is a table of this job's results, obtained by running the benchmarks.
Benchmark Group ListHere's a list of all the benchmark groups executed by this job:
Julia versioninfoRuntime information
Architecture: x86_64
|
```julia
julia> function compute(x)
r = 1
s = 0.0
n = 1
@time while r < x
s += 1/n
if s ≥ r
println("round $r/$x has been finished") # we're not interested type-instabilities within this call
r += 1
end
n += 1
end
return n, s
end
compute (generic function with 1 method)
julia> @test_opt ignored_modules=(Base,) compute(42)
Test Passed
```
Also extends the existing `target_modules` so that user can specify how
module context is matched with `InferenceErrorReport`'s stack trace.
This commit also implements additional configuration layers that let
users to implement their own module context matcher and report filtering
strategy in general. We should still try to improve their documentation
though.
|
This is a great addition, thank you! I am trying to use it, but I am hitting a small problem. I have a small library that uses
|
|
It seems like the type instability comes from julia> @report_call ignored_modules=(AnyFrameModule(Graphs.LinAlg),) adjacency_matrix(g)
No errors detected |
|
Thank you! I had misunderstood how modules inside of module work. |
Also extends the existing
target_modulesso that user can specify howmodule context is matched with
InferenceErrorReport's stack trace.This commit also implements additional configuration layers that let
users to implement their own module context matcher and report filtering
strategy in general. We should still try to improve their documentation
though.