alternative for #46, hybrid approach: #47
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- toplevel method definition - closures
- selective interpretation for non-abstract statements - then profile on toplevel `MethodInstance`
… by `profile_toplevel!`
aviatesk
changed the title
Codecov Report
@@ Coverage Diff @@
## master #47 +/- ##
==========================================
- Coverage 85.69% 80.15% -5.54%
==========================================
Files 9 18 +9
Lines 706 1401 +695
==========================================
+ Hits 605 1123 +518
- Misses 101 278 +177
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
|
okay, this is in pretty good shape, now |
timholy
reviewed
Feb 3, 2022
|
|
||
| # adapted from https://github.com/JuliaDebug/JuliaInterpreter.jl/blob/2f5f80034bc287a60fe77c4e3b5a49a087e38f8b/src/interpret.jl#L188-L199 | ||
| # works as `JuliaInterpreter.evaluate_call_compiled!`, but special cases for TypeProfiler.jl added | ||
| function evaluate_call_recurse!(interp::ActualInterpreter, frame::Frame, call_expr::Expr; enter_generated::Bool=false) |
There was a problem hiding this comment.
Today I noticed that defining this method triggers more than 500 invalidations if you've loaded Revise. (In contrast, extending step_expr! only triggered 8 invalidations, though if one gets fixed it might alter the count for the other.) We can live with that, but it might also be worth considering whether there are alternatives:
- define some inner call in JuliaInterpreter's
evaluate_call_recurse!method that obviates the need for this extension (i.e., can we add a branch that handlesincludes?) - move the definition of
ConcreteInterpreterand this second method to JuliaInterpreter.jl (I suspect that is not a good solution) - always use runtime dispatch to call
evaluate_call_recurse!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
MethodInstanceeventually closes #26 , #46