Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

remove the hack added in #498 to avoid InitError #500

Merged
merged 1 commit into from Apr 27, 2023
Merged

remove the hack added in #498 to avoid InitError #500

merged 1 commit into from Apr 27, 2023

Conversation

aviatesk
Copy link
Owner

closes #499

@codecov-commenter
Copy link

codecov-commenter commented Apr 27, 2023 •
edited

Codecov Report

Patch and project coverage have no change.

Comparison is base (b61b39b) 90.92% compared to head (0135ecd) 90.93%.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

Additional details and impacted files 
@@           Coverage Diff           @@
##           master     #500   +/-   ##
=======================================
  Coverage   90.92%   90.93%           
=======================================
  Files          10       10           
  Lines        2975     2967    -8     
=======================================
- Hits         2705     2698    -7     
+ Misses        270      269    -1
Impacted Files Coverage Δ
src/toplevel/virtualprocess.jl 96.51% <ø> (+0.26%) ⬆️

... and 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@github-actions
Copy link

JET Benchmark Result

Judge result

Benchmark Report for /home/runner/work/JET.jl/JET.jl

Job Properties

  • Time of benchmarks:
  • Target: 27 Apr 2023 - 05:12
  • Baseline: 27 Apr 2023 - 05:24
  • Package commits:
  • Target: a1b83c
  • Baseline: b61b39
  • Julia commits:
  • Target: b3bbd5
  • Baseline: b3bbd5
  • Julia command flags:
  • Target: None
  • Baseline: None
  • Environment variables:
  • Target: None
  • Baseline: None

Results

A ratio greater than 1.0 denotes a possible regression (marked with ❌), while a ratio less
than 1.0 denotes a possible improvement (marked with ✅). Only significant results - results
that indicate possible regressions or improvements - are shown below (thus, an empty table means that all
benchmark results remained invariant between builds).

ID time ratio memory ratio
["First-Time-To-JET", "package loading"] 0.94 (5%) ✅ 1.00 (1%)
["First-Time-To-JET", "rand(Bool)"] 0.85 (5%) ✅ 1.00 (1%)
["First-Time-To-JET", "sum(\"julia\")"] 1.39 (5%) ❌ 1.00 (1%)
["JETAnalyzer{BasicPass}", "identity(nothing)"] 0.79 (5%) ✅ 1.00 (1%)
["JETAnalyzer{BasicPass}", "sum(\"julia\") (cached)"] 0.87 (5%) ✅ 1.00 (1%)
["JETAnalyzer{SoundPass}", "identity(nothing)"] 1.06 (5%) ❌ 1.00 (1%)
["JETAnalyzer{SoundPass}", "rand(Bool)"] 1.06 (5%) ❌ 1.00 (1%)
["JETAnalyzer{SoundPass}", "sum(\"julia\")"] 1.09 (5%) ❌ 1.00 (1%)
["OptAnalyzer", "identity(nothing)"] 0.89 (5%) ✅ 1.00 (1%)
["OptAnalyzer", "println(QuoteNode(nothing))"] 1.22 (5%) ❌ 1.00 (1%)
["OptAnalyzer", "sum(\"julia\")"] 1.29 (5%) ❌ 1.00 (1%)
["show(::IO, ::JETCallResult)", "report_opt"] 0.42 (5%) ✅ 1.00 (1%)

Benchmark Group List

Here's a list of all the benchmark groups executed by this job:

  • ["First-Time-To-JET"]
  • ["JETAnalyzer{BasicPass} top-level"]
  • ["JETAnalyzer{BasicPass}"]
  • ["JETAnalyzer{SoundPass}"]
  • ["OptAnalyzer"]
  • ["show(::IO, ::JETCallResult)"]

Julia versioninfo

Target

Julia Version 1.10.0-DEV.1124
Commit b3bbd5b7aa6 (2023-04-26 23:02 UTC)
Platform Info:
 OS: Linux (x86_64-linux-gnu)
 Ubuntu 22.04.2 LTS
 uname: Linux 5.15.0-1036-azure #43-Ubuntu SMP Wed Mar 29 16:11:05 UTC 2023 x86_64 x86_64
 CPU: Intel(R) Xeon(R) Platinum 8272CL CPU @ 2.60GHz: 
 speed user nice sys idle irq
 #1 2593 MHz 6263 s 0 s 232 s 5177 s 0 s
 #2 2593 MHz 2944 s 0 s 271 s 8428 s 0 s
 Memory: 6.781208038330078 GB (4602.57421875 MB free)
 Uptime: 1176.09 sec
 Load Avg: 1.0 1.0 0.71
 WORD_SIZE: 64
 LIBM: libopenlibm
 LLVM: libLLVM-14.0.6 (ORCJIT, skylake-avx512)
 Threads: 1 on 2 virtual cores

Baseline

Julia Version 1.10.0-DEV.1124
Commit b3bbd5b7aa6 (2023-04-26 23:02 UTC)
Platform Info:
 OS: Linux (x86_64-linux-gnu)
 Ubuntu 22.04.2 LTS
 uname: Linux 5.15.0-1036-azure #43-Ubuntu SMP Wed Mar 29 16:11:05 UTC 2023 x86_64 x86_64
 CPU: Intel(R) Xeon(R) Platinum 8272CL CPU @ 2.60GHz: 
 speed user nice sys idle irq
 #1 2593 MHz 12525 s 0 s 353 s 6079 s 0 s
 #2 2593 MHz 3968 s 0 s 341 s 14586 s 0 s
 Memory: 6.781208038330078 GB (4579.3828125 MB free)
 Uptime: 1905.24 sec
 Load Avg: 1.01 1.01 0.91
 WORD_SIZE: 64
 LIBM: libopenlibm
 LLVM: libLLVM-14.0.6 (ORCJIT, skylake-avx512)
 Threads: 1 on 2 virtual cores

Target result

Benchmark Report for /home/runner/work/JET.jl/JET.jl

Job Properties

  • Time of benchmark: 27 Apr 2023 - 5:12
  • Package commit: a1b83c
  • Julia commit: b3bbd5
  • Julia command flags: None
  • Environment variables: None

Results

Below is a table of this job's results, obtained by running the benchmarks.
The values listed in the ID column have the structure [parent_group, child_group, ..., key], and can be used to
index into the BaseBenchmarks suite to retrieve the corresponding benchmarks.
The percentages accompanying time and memory values in the below table are noise tolerances. The "true"
time/memory value for a given benchmark is expected to fall within this percentage of the reported value.
An empty cell means that the value was zero.

ID time GC time memory allocations
["First-Time-To-JET", "package loading"] 293.716 ms (5%) 64.73 KiB (1%) 19
["First-Time-To-JET", "rand(Bool)"] 721.532 ms (5%) 65.14 KiB (1%) 19
["First-Time-To-JET", "sum(\"julia\")"] 443.207 ms (5%) 65.14 KiB (1%) 19
["JETAnalyzer{BasicPass} top-level", "demo"] 50.662 ms (5%) 2.17 MiB (1%) 38256
["JETAnalyzer{BasicPass} top-level", "self analysis"] 18.954 s (5%) 2.104 s 1.03 GiB (1%) 19047302
["JETAnalyzer{BasicPass} top-level", "simple"] 14.410 ms (5%) 2.08 MiB (1%) 35865
["JETAnalyzer{BasicPass}", "identity(nothing)"] 137.403 μs (5%) 7.38 KiB (1%) 106
["JETAnalyzer{BasicPass}", "println(QuoteNode(nothing))"] 216.715 ms (5%) 38.43 MiB (1%) 727893
["JETAnalyzer{BasicPass}", "rand(Bool)"] 68.516 ms (5%) 14.40 MiB (1%) 264172
["JETAnalyzer{BasicPass}", "sum(\"julia\") (cached)"] 238.105 μs (5%) 17.33 KiB (1%) 229
["JETAnalyzer{BasicPass}", "sum(\"julia\")"] 8.985 ms (5%) 1.93 MiB (1%) 33581
["JETAnalyzer{SoundPass}", "identity(nothing)"] 141.303 μs (5%) 7.38 KiB (1%) 106
["JETAnalyzer{SoundPass}", "println(QuoteNode(nothing))"] 355.464 ms (5%) 52.442 ms 62.03 MiB (1%) 876115
["JETAnalyzer{SoundPass}", "rand(Bool)"] 88.336 ms (5%) 18.06 MiB (1%) 298627
["JETAnalyzer{SoundPass}", "sum(\"julia\") (cached)"] 8.304 s (5%) 74.439 ms 21.83 MiB (1%) 406877
["JETAnalyzer{SoundPass}", "sum(\"julia\")"] 10.347 ms (5%) 2.04 MiB (1%) 35553
["OptAnalyzer", "identity(nothing)"] 212.905 μs (5%) 25.61 KiB (1%) 370
["OptAnalyzer", "println(QuoteNode(nothing))"] 787.296 ms (5%) 101.435 ms 198.04 MiB (1%) 2932262
["OptAnalyzer", "rand(Bool)"] 37.885 ms (5%) 11.81 MiB (1%) 177771
["OptAnalyzer", "sum(\"julia\") (cached)"] 367.108 μs (5%) 59.66 KiB (1%) 821
["OptAnalyzer", "sum(\"julia\")"] 22.550 ms (5%) 5.82 MiB (1%) 86982
["show(::IO, ::JETCallResult)", "report_call"] 2.270 ms (5%) 274.89 KiB (1%) 5080
["show(::IO, ::JETCallResult)", "report_opt"] 43.601 μs (5%) 632 bytes (1%) 14

Benchmark Group List

Here's a list of all the benchmark groups executed by this job:

  • ["First-Time-To-JET"]
  • ["JETAnalyzer{BasicPass} top-level"]
  • ["JETAnalyzer{BasicPass}"]
  • ["JETAnalyzer{SoundPass}"]
  • ["OptAnalyzer"]
  • ["show(::IO, ::JETCallResult)"]

Julia versioninfo

Julia Version 1.10.0-DEV.1124
Commit b3bbd5b7aa6 (2023-04-26 23:02 UTC)
Platform Info:
 OS: Linux (x86_64-linux-gnu)
 Ubuntu 22.04.2 LTS
 uname: Linux 5.15.0-1036-azure #43-Ubuntu SMP Wed Mar 29 16:11:05 UTC 2023 x86_64 x86_64
 CPU: Intel(R) Xeon(R) Platinum 8272CL CPU @ 2.60GHz: 
 speed user nice sys idle irq
 #1 2593 MHz 6263 s 0 s 232 s 5177 s 0 s
 #2 2593 MHz 2944 s 0 s 271 s 8428 s 0 s
 Memory: 6.781208038330078 GB (4602.57421875 MB free)
 Uptime: 1176.09 sec
 Load Avg: 1.0 1.0 0.71
 WORD_SIZE: 64
 LIBM: libopenlibm
 LLVM: libLLVM-14.0.6 (ORCJIT, skylake-avx512)
 Threads: 1 on 2 virtual cores

Baseline result

Benchmark Report for /home/runner/work/JET.jl/JET.jl

Job Properties

  • Time of benchmark: 27 Apr 2023 - 5:24
  • Package commit: b61b39
  • Julia commit: b3bbd5
  • Julia command flags: None
  • Environment variables: None

Results

Below is a table of this job's results, obtained by running the benchmarks.
The values listed in the ID column have the structure [parent_group, child_group, ..., key], and can be used to
index into the BaseBenchmarks suite to retrieve the corresponding benchmarks.
The percentages accompanying time and memory values in the below table are noise tolerances. The "true"
time/memory value for a given benchmark is expected to fall within this percentage of the reported value.
An empty cell means that the value was zero.

ID time GC time memory allocations
["First-Time-To-JET", "package loading"] 311.027 ms (5%) 64.73 KiB (1%) 19
["First-Time-To-JET", "rand(Bool)"] 851.064 ms (5%) 65.14 KiB (1%) 19
["First-Time-To-JET", "sum(\"julia\")"] 318.372 ms (5%) 65.14 KiB (1%) 19
["JETAnalyzer{BasicPass} top-level", "demo"] 50.876 ms (5%) 2.17 MiB (1%) 38256
["JETAnalyzer{BasicPass} top-level", "self analysis"] 18.976 s (5%) 2.133 s 1.03 GiB (1%) 19047634
["JETAnalyzer{BasicPass} top-level", "simple"] 14.952 ms (5%) 2.08 MiB (1%) 35865
["JETAnalyzer{BasicPass}", "identity(nothing)"] 174.003 μs (5%) 7.38 KiB (1%) 106
["JETAnalyzer{BasicPass}", "println(QuoteNode(nothing))"] 213.820 ms (5%) 38.43 MiB (1%) 727893
["JETAnalyzer{BasicPass}", "rand(Bool)"] 69.539 ms (5%) 14.41 MiB (1%) 264173
["JETAnalyzer{BasicPass}", "sum(\"julia\") (cached)"] 274.006 μs (5%) 17.33 KiB (1%) 229
["JETAnalyzer{BasicPass}", "sum(\"julia\")"] 8.984 ms (5%) 1.93 MiB (1%) 33581
["JETAnalyzer{SoundPass}", "identity(nothing)"] 133.103 μs (5%) 7.38 KiB (1%) 106
["JETAnalyzer{SoundPass}", "println(QuoteNode(nothing))"] 360.592 ms (5%) 55.816 ms 62.03 MiB (1%) 876115
["JETAnalyzer{SoundPass}", "rand(Bool)"] 83.632 ms (5%) 18.06 MiB (1%) 298627
["JETAnalyzer{SoundPass}", "sum(\"julia\") (cached)"] 8.685 s (5%) 78.272 ms 21.83 MiB (1%) 406877
["JETAnalyzer{SoundPass}", "sum(\"julia\")"] 9.468 ms (5%) 2.04 MiB (1%) 35552
["OptAnalyzer", "identity(nothing)"] 240.205 μs (5%) 25.61 KiB (1%) 370
["OptAnalyzer", "println(QuoteNode(nothing))"] 646.375 ms (5%) 77.890 ms 198.04 MiB (1%) 2932262
["OptAnalyzer", "rand(Bool)"] 38.060 ms (5%) 11.81 MiB (1%) 177771
["OptAnalyzer", "sum(\"julia\") (cached)"] 380.208 μs (5%) 59.66 KiB (1%) 821
["OptAnalyzer", "sum(\"julia\")"] 17.517 ms (5%) 5.82 MiB (1%) 86982
["show(::IO, ::JETCallResult)", "report_call"] 2.371 ms (5%) 274.89 KiB (1%) 5080
["show(::IO, ::JETCallResult)", "report_opt"] 103.102 μs (5%) 632 bytes (1%) 14

Benchmark Group List

Here's a list of all the benchmark groups executed by this job:

  • ["First-Time-To-JET"]
  • ["JETAnalyzer{BasicPass} top-level"]
  • ["JETAnalyzer{BasicPass}"]
  • ["JETAnalyzer{SoundPass}"]
  • ["OptAnalyzer"]
  • ["show(::IO, ::JETCallResult)"]

Julia versioninfo

Julia Version 1.10.0-DEV.1124
Commit b3bbd5b7aa6 (2023-04-26 23:02 UTC)
Platform Info:
 OS: Linux (x86_64-linux-gnu)
 Ubuntu 22.04.2 LTS
 uname: Linux 5.15.0-1036-azure #43-Ubuntu SMP Wed Mar 29 16:11:05 UTC 2023 x86_64 x86_64
 CPU: Intel(R) Xeon(R) Platinum 8272CL CPU @ 2.60GHz: 
 speed user nice sys idle irq
 #1 2593 MHz 12525 s 0 s 353 s 6079 s 0 s
 #2 2593 MHz 3968 s 0 s 341 s 14586 s 0 s
 Memory: 6.781208038330078 GB (4579.3828125 MB free)
 Uptime: 1905.24 sec
 Load Avg: 1.01 1.01 0.91
 WORD_SIZE: 64
 LIBM: libopenlibm
 LLVM: libLLVM-14.0.6 (ORCJIT, skylake-avx512)
 Threads: 1 on 2 virtual cores

Runtime information

Runtime Info
BLAS #threads 1
BLAS.vendor() lbt
Sys.CPU_THREADS 2

lscpu output:

Architecture: x86_64
CPU op-mode(s): 32-bit, 64-bit
Address sizes: 46 bits physical, 48 bits virtual
Byte Order: Little Endian
CPU(s): 2
On-line CPU(s) list: 0,1
Vendor ID: GenuineIntel
Model name: Intel(R) Xeon(R) Platinum 8272CL CPU @ 2.60GHz
CPU family: 6
Model: 85
Thread(s) per core: 1
Core(s) per socket: 2
Socket(s): 1
Stepping: 7
BogoMIPS: 5187.81
Flags: fpu vme de pse tsc msr pae mce cx8 apic sep mtrr pge mca cmov pat pse36 clflush mmx fxsr sse sse2 ss ht syscall nx pdpe1gb rdtscp lm constant_tsc rep_good nopl xtopology cpuid pni pclmulqdq ssse3 fma cx16 pcid sse4_1 sse4_2 movbe popcnt aes xsave avx f16c rdrand hypervisor lahf_lm abm 3dnowprefetch invpcid_single pti fsgsbase bmi1 hle avx2 smep bmi2 erms invpcid rtm avx512f avx512dq rdseed adx smap clflushopt avx512cd avx512bw avx512vl xsaveopt xsavec xsaves md_clear
Hypervisor vendor: Microsoft
Virtualization type: full
L1d cache: 64 KiB (2 instances)
L1i cache: 64 KiB (2 instances)
L2 cache: 2 MiB (2 instances)
L3 cache: 35.8 MiB (1 instance)
NUMA node(s): 1
NUMA node0 CPU(s): 0,1
Vulnerability Itlb multihit: KVM: Mitigation: VMX unsupported
Vulnerability L1tf: Mitigation; PTE Inversion
Vulnerability Mds: Mitigation; Clear CPU buffers; SMT Host state unknown
Vulnerability Meltdown: Mitigation; PTI
Vulnerability Mmio stale data: Vulnerable: Clear CPU buffers attempted, no microcode; SMT Host state unknown
Vulnerability Retbleed: Vulnerable
Vulnerability Spec store bypass: Vulnerable
Vulnerability Spectre v1: Mitigation; usercopy/swapgs barriers and __user pointer sanitization
Vulnerability Spectre v2: Mitigation; Retpolines, STIBP disabled, RSB filling, PBRSB-eIBRS Not affected
Vulnerability Srbds: Not affected
Vulnerability Tsx async abort: Mitigation; Clear CPU buffers; SMT Host state unknown

Cpu Property Value
Brand Intel(R) Xeon(R) Platinum 8272CL CPU @ 2.60GHz
Vendor :Intel
Architecture :Skylake
Model Family: 0x06, Model: 0x55, Stepping: 0x07, Type: 0x00
Cores 2 physical cores, 2 logical cores (on executing CPU)
No Hyperthreading hardware capability detected
Clock Frequencies Not supported by CPU
Data Cache Level 1:3 : (32, 1024, 36608) kbytes
64 byte cache line size
Address Size 48 bits virtual, 46 bits physical
SIMD 512 bit = 64 byte max. SIMD vector size
Time Stamp Counter TSC is accessible via rdtsc
TSC increased at every clock cycle (non-invariant TSC)
Perf. Monitoring Performance Monitoring Counters (PMC) are not supported
Hypervisor Yes, Microsoft

@aviatesk aviatesk merged commit f9141a0 into master Apr 27, 2023
20 checks passed
@aviatesk aviatesk deleted the avi/499 branch April 27, 2023 05:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

JET breaks SnoopCompile
2 participants
@aviatesk @codecov-commenter