Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bump Preferences.jl version for complete fix of #498 #503

Merged
merged 1 commit into from
May 5, 2023

Conversation

aviatesk
Copy link
Owner

@aviatesk aviatesk commented May 5, 2023

No description provided.

@codecov-commenter
Copy link

codecov-commenter commented May 5, 2023

Codecov Report

Patch coverage: 100.00% and no project coverage change.

Comparison is base (289db4d) 90.93% compared to head (6aa24cd) 90.93%.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #503   +/-   ##
=======================================
  Coverage   90.93%   90.93%           
=======================================
  Files          10       10           
  Lines        2967     2969    +2     
=======================================
+ Hits         2698     2700    +2     
  Misses        269      269           
Impacted Files Coverage Δ
src/toplevel/virtualprocess.jl 96.52% <100.00%> (+0.01%) ⬆️

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@github-actions
Copy link

github-actions bot commented May 5, 2023

JET Benchmark Result

Judge result

Benchmark Report for /home/runner/work/JET.jl/JET.jl

Job Properties

  • Time of benchmarks:
  • Target: 5 May 2023 - 05:09
  • Baseline: 5 May 2023 - 05:21
  • Package commits:
  • Target: b078ff
  • Baseline: 289db4
  • Julia commits:
  • Target: 5e7d7c
  • Baseline: 5e7d7c
  • Julia command flags:
  • Target: None
  • Baseline: None
  • Environment variables:
  • Target: None
  • Baseline: None

Results

A ratio greater than 1.0 denotes a possible regression (marked with ❌), while a ratio less
than 1.0 denotes a possible improvement (marked with ✅). Only significant results - results
that indicate possible regressions or improvements - are shown below (thus, an empty table means that all
benchmark results remained invariant between builds).

ID time ratio memory ratio
["First-Time-To-JET", "sum(\"julia\")"] 1.32 (5%) ❌ 1.00 (1%)
["JETAnalyzer{BasicPass}", "sum(\"julia\")"] 1.08 (5%) ❌ 1.00 (1%)
["JETAnalyzer{SoundPass}", "sum(\"julia\")"] 1.06 (5%) ❌ 1.00 (1%)
["show(::IO, ::JETCallResult)", "report_opt"] 0.93 (5%) ✅ 1.00 (1%)

Benchmark Group List

Here's a list of all the benchmark groups executed by this job:

  • ["First-Time-To-JET"]
  • ["JETAnalyzer{BasicPass} top-level"]
  • ["JETAnalyzer{BasicPass}"]
  • ["JETAnalyzer{SoundPass}"]
  • ["OptAnalyzer"]
  • ["show(::IO, ::JETCallResult)"]

Julia versioninfo

Target

Julia Version 1.10.0-DEV.1198
Commit 5e7d7c3eeb7 (2023-05-04 13:15 UTC)
Platform Info:
 OS: Linux (x86_64-linux-gnu)
 Ubuntu 22.04.2 LTS
 uname: Linux 5.15.0-1036-azure #43-Ubuntu SMP Wed Mar 29 16:11:05 UTC 2023 x86_64 x86_64
 CPU: Intel(R) Xeon(R) Platinum 8272CL CPU @ 2.60GHz: 
 speed user nice sys idle irq
 #1 2593 MHz 6457 s 0 s 172 s 3141 s 0 s
 #2 2593 MHz 2777 s 0 s 270 s 6690 s 0 s
 Memory: 6.7812042236328125 GB (4395.484375 MB free)
 Uptime: 982.47 sec
 Load Avg: 1.0 1.0 0.76
 WORD_SIZE: 64
 LIBM: libopenlibm
 LLVM: libLLVM-14.0.6 (ORCJIT, skylake-avx512)
 Threads: 1 on 2 virtual cores

Baseline

Julia Version 1.10.0-DEV.1198
Commit 5e7d7c3eeb7 (2023-05-04 13:15 UTC)
Platform Info:
 OS: Linux (x86_64-linux-gnu)
 Ubuntu 22.04.2 LTS
 uname: Linux 5.15.0-1036-azure #43-Ubuntu SMP Wed Mar 29 16:11:05 UTC 2023 x86_64 x86_64
 CPU: Intel(R) Xeon(R) Platinum 8272CL CPU @ 2.60GHz: 
 speed user nice sys idle irq
 #1 2593 MHz 12850 s 0 s 232 s 3899 s 0 s
 #2 2593 MHz 3582 s 0 s 365 s 12978 s 0 s
 Memory: 6.7812042236328125 GB (4440.02734375 MB free)
 Uptime: 1703.8 sec
 Load Avg: 1.02 1.03 0.93
 WORD_SIZE: 64
 LIBM: libopenlibm
 LLVM: libLLVM-14.0.6 (ORCJIT, skylake-avx512)
 Threads: 1 on 2 virtual cores

Target result

Benchmark Report for /home/runner/work/JET.jl/JET.jl

Job Properties

  • Time of benchmark: 5 May 2023 - 5:9
  • Package commit: b078ff
  • Julia commit: 5e7d7c
  • Julia command flags: None
  • Environment variables: None

Results

Below is a table of this job's results, obtained by running the benchmarks.
The values listed in the ID column have the structure [parent_group, child_group, ..., key], and can be used to
index into the BaseBenchmarks suite to retrieve the corresponding benchmarks.
The percentages accompanying time and memory values in the below table are noise tolerances. The "true"
time/memory value for a given benchmark is expected to fall within this percentage of the reported value.
An empty cell means that the value was zero.

ID time GC time memory allocations
["First-Time-To-JET", "package loading"] 62.289 s (5%) 187.27 KiB (1%) 1723
["First-Time-To-JET", "rand(Bool)"] 648.045 ms (5%) 65.14 KiB (1%) 19
["First-Time-To-JET", "sum(\"julia\")"] 343.316 ms (5%) 65.14 KiB (1%) 19
["JETAnalyzer{BasicPass} top-level", "demo"] 42.779 ms (5%) 2.17 MiB (1%) 38262
["JETAnalyzer{BasicPass} top-level", "self analysis"] 12.620 s (5%) 1.201 s 1.03 GiB (1%) 19007013
["JETAnalyzer{BasicPass} top-level", "simple"] 9.604 ms (5%) 2.08 MiB (1%) 35865
["JETAnalyzer{BasicPass}", "identity(nothing)"] 93.201 μs (5%) 7.38 KiB (1%) 106
["JETAnalyzer{BasicPass}", "println(QuoteNode(nothing))"] 185.229 ms (5%) 38.45 MiB (1%) 728325
["JETAnalyzer{BasicPass}", "rand(Bool)"] 54.447 ms (5%) 14.40 MiB (1%) 263971
["JETAnalyzer{BasicPass}", "sum(\"julia\") (cached)"] 180.602 μs (5%) 17.33 KiB (1%) 229
["JETAnalyzer{BasicPass}", "sum(\"julia\")"] 7.445 ms (5%) 1.93 MiB (1%) 33581
["JETAnalyzer{SoundPass}", "identity(nothing)"] 94.101 μs (5%) 7.38 KiB (1%) 106
["JETAnalyzer{SoundPass}", "println(QuoteNode(nothing))"] 279.913 ms (5%) 36.190 ms 62.13 MiB (1%) 876364
["JETAnalyzer{SoundPass}", "rand(Bool)"] 63.731 ms (5%) 18.07 MiB (1%) 298285
["JETAnalyzer{SoundPass}", "sum(\"julia\") (cached)"] 6.304 s (5%) 31.166 ms 21.68 MiB (1%) 404097
["JETAnalyzer{SoundPass}", "sum(\"julia\")"] 7.621 ms (5%) 2.04 MiB (1%) 35552
["OptAnalyzer", "identity(nothing)"] 145.202 μs (5%) 25.61 KiB (1%) 370
["OptAnalyzer", "println(QuoteNode(nothing))"] 638.141 ms (5%) 69.532 ms 201.60 MiB (1%) 2981817
["OptAnalyzer", "rand(Bool)"] 31.442 ms (5%) 13.68 MiB (1%) 203028
["OptAnalyzer", "sum(\"julia\") (cached)"] 297.103 μs (5%) 59.66 KiB (1%) 821
["OptAnalyzer", "sum(\"julia\")"] 14.683 ms (5%) 5.82 MiB (1%) 86982
["show(::IO, ::JETCallResult)", "report_call"] 1.454 ms (5%) 274.89 KiB (1%) 5080
["show(::IO, ::JETCallResult)", "report_opt"] 20.701 μs (5%) 632 bytes (1%) 14

Benchmark Group List

Here's a list of all the benchmark groups executed by this job:

  • ["First-Time-To-JET"]
  • ["JETAnalyzer{BasicPass} top-level"]
  • ["JETAnalyzer{BasicPass}"]
  • ["JETAnalyzer{SoundPass}"]
  • ["OptAnalyzer"]
  • ["show(::IO, ::JETCallResult)"]

Julia versioninfo

Julia Version 1.10.0-DEV.1198
Commit 5e7d7c3eeb7 (2023-05-04 13:15 UTC)
Platform Info:
 OS: Linux (x86_64-linux-gnu)
 Ubuntu 22.04.2 LTS
 uname: Linux 5.15.0-1036-azure #43-Ubuntu SMP Wed Mar 29 16:11:05 UTC 2023 x86_64 x86_64
 CPU: Intel(R) Xeon(R) Platinum 8272CL CPU @ 2.60GHz: 
 speed user nice sys idle irq
 #1 2593 MHz 6457 s 0 s 172 s 3141 s 0 s
 #2 2593 MHz 2777 s 0 s 270 s 6690 s 0 s
 Memory: 6.7812042236328125 GB (4395.484375 MB free)
 Uptime: 982.47 sec
 Load Avg: 1.0 1.0 0.76
 WORD_SIZE: 64
 LIBM: libopenlibm
 LLVM: libLLVM-14.0.6 (ORCJIT, skylake-avx512)
 Threads: 1 on 2 virtual cores

Baseline result

Benchmark Report for /home/runner/work/JET.jl/JET.jl

Job Properties

  • Time of benchmark: 5 May 2023 - 5:21
  • Package commit: 289db4
  • Julia commit: 5e7d7c
  • Julia command flags: None
  • Environment variables: None

Results

Below is a table of this job's results, obtained by running the benchmarks.
The values listed in the ID column have the structure [parent_group, child_group, ..., key], and can be used to
index into the BaseBenchmarks suite to retrieve the corresponding benchmarks.
The percentages accompanying time and memory values in the below table are noise tolerances. The "true"
time/memory value for a given benchmark is expected to fall within this percentage of the reported value.
An empty cell means that the value was zero.

ID time GC time memory allocations
["First-Time-To-JET", "package loading"] 62.377 s (5%) 187.27 KiB (1%) 1723
["First-Time-To-JET", "rand(Bool)"] 651.656 ms (5%) 65.14 KiB (1%) 19
["First-Time-To-JET", "sum(\"julia\")"] 261.046 ms (5%) 65.14 KiB (1%) 19
["JETAnalyzer{BasicPass} top-level", "demo"] 42.435 ms (5%) 2.17 MiB (1%) 38262
["JETAnalyzer{BasicPass} top-level", "self analysis"] 12.897 s (5%) 1.441 s 1.03 GiB (1%) 19006286
["JETAnalyzer{BasicPass} top-level", "simple"] 9.778 ms (5%) 2.08 MiB (1%) 35865
["JETAnalyzer{BasicPass}", "identity(nothing)"] 94.300 μs (5%) 7.38 KiB (1%) 106
["JETAnalyzer{BasicPass}", "println(QuoteNode(nothing))"] 185.259 ms (5%) 38.45 MiB (1%) 728326
["JETAnalyzer{BasicPass}", "rand(Bool)"] 52.838 ms (5%) 14.46 MiB (1%) 263974
["JETAnalyzer{BasicPass}", "sum(\"julia\") (cached)"] 178.700 μs (5%) 17.33 KiB (1%) 229
["JETAnalyzer{BasicPass}", "sum(\"julia\")"] 6.871 ms (5%) 1.93 MiB (1%) 33581
["JETAnalyzer{SoundPass}", "identity(nothing)"] 93.700 μs (5%) 7.38 KiB (1%) 106
["JETAnalyzer{SoundPass}", "println(QuoteNode(nothing))"] 278.509 ms (5%) 37.812 ms 62.13 MiB (1%) 876365
["JETAnalyzer{SoundPass}", "rand(Bool)"] 64.426 ms (5%) 18.13 MiB (1%) 298288
["JETAnalyzer{SoundPass}", "sum(\"julia\") (cached)"] 6.170 s (5%) 50.492 ms 21.68 MiB (1%) 404097
["JETAnalyzer{SoundPass}", "sum(\"julia\")"] 7.200 ms (5%) 2.04 MiB (1%) 35552
["OptAnalyzer", "identity(nothing)"] 146.602 μs (5%) 25.61 KiB (1%) 370
["OptAnalyzer", "println(QuoteNode(nothing))"] 620.780 ms (5%) 68.006 ms 201.60 MiB (1%) 2981824
["OptAnalyzer", "rand(Bool)"] 31.412 ms (5%) 13.68 MiB (1%) 203029
["OptAnalyzer", "sum(\"julia\") (cached)"] 305.403 μs (5%) 59.66 KiB (1%) 821
["OptAnalyzer", "sum(\"julia\")"] 14.468 ms (5%) 5.82 MiB (1%) 86982
["show(::IO, ::JETCallResult)", "report_call"] 1.434 ms (5%) 274.89 KiB (1%) 5080
["show(::IO, ::JETCallResult)", "report_opt"] 22.201 μs (5%) 632 bytes (1%) 14

Benchmark Group List

Here's a list of all the benchmark groups executed by this job:

  • ["First-Time-To-JET"]
  • ["JETAnalyzer{BasicPass} top-level"]
  • ["JETAnalyzer{BasicPass}"]
  • ["JETAnalyzer{SoundPass}"]
  • ["OptAnalyzer"]
  • ["show(::IO, ::JETCallResult)"]

Julia versioninfo

Julia Version 1.10.0-DEV.1198
Commit 5e7d7c3eeb7 (2023-05-04 13:15 UTC)
Platform Info:
 OS: Linux (x86_64-linux-gnu)
 Ubuntu 22.04.2 LTS
 uname: Linux 5.15.0-1036-azure #43-Ubuntu SMP Wed Mar 29 16:11:05 UTC 2023 x86_64 x86_64
 CPU: Intel(R) Xeon(R) Platinum 8272CL CPU @ 2.60GHz: 
 speed user nice sys idle irq
 #1 2593 MHz 12850 s 0 s 232 s 3899 s 0 s
 #2 2593 MHz 3582 s 0 s 365 s 12978 s 0 s
 Memory: 6.7812042236328125 GB (4440.02734375 MB free)
 Uptime: 1703.8 sec
 Load Avg: 1.02 1.03 0.93
 WORD_SIZE: 64
 LIBM: libopenlibm
 LLVM: libLLVM-14.0.6 (ORCJIT, skylake-avx512)
 Threads: 1 on 2 virtual cores

Runtime information

Runtime Info
BLAS #threads 1
BLAS.vendor() lbt
Sys.CPU_THREADS 2

lscpu output:

Architecture: x86_64
CPU op-mode(s): 32-bit, 64-bit
Address sizes: 46 bits physical, 48 bits virtual
Byte Order: Little Endian
CPU(s): 2
On-line CPU(s) list: 0,1
Vendor ID: GenuineIntel
Model name: Intel(R) Xeon(R) Platinum 8272CL CPU @ 2.60GHz
CPU family: 6
Model: 85
Thread(s) per core: 1
Core(s) per socket: 2
Socket(s): 1
Stepping: 7
BogoMIPS: 5187.81
Flags: fpu vme de pse tsc msr pae mce cx8 apic sep mtrr pge mca cmov pat pse36 clflush mmx fxsr sse sse2 ss ht syscall nx pdpe1gb rdtscp lm constant_tsc rep_good nopl xtopology cpuid pni pclmulqdq ssse3 fma cx16 pcid sse4_1 sse4_2 movbe popcnt aes xsave avx f16c rdrand hypervisor lahf_lm abm 3dnowprefetch invpcid_single pti fsgsbase bmi1 hle avx2 smep bmi2 erms invpcid rtm avx512f avx512dq rdseed adx smap clflushopt avx512cd avx512bw avx512vl xsaveopt xsavec xsaves md_clear
Hypervisor vendor: Microsoft
Virtualization type: full
L1d cache: 64 KiB (2 instances)
L1i cache: 64 KiB (2 instances)
L2 cache: 2 MiB (2 instances)
L3 cache: 35.8 MiB (1 instance)
NUMA node(s): 1
NUMA node0 CPU(s): 0,1
Vulnerability Itlb multihit: KVM: Mitigation: VMX unsupported
Vulnerability L1tf: Mitigation; PTE Inversion
Vulnerability Mds: Mitigation; Clear CPU buffers; SMT Host state unknown
Vulnerability Meltdown: Mitigation; PTI
Vulnerability Mmio stale data: Vulnerable: Clear CPU buffers attempted, no microcode; SMT Host state unknown
Vulnerability Retbleed: Vulnerable
Vulnerability Spec store bypass: Vulnerable
Vulnerability Spectre v1: Mitigation; usercopy/swapgs barriers and __user pointer sanitization
Vulnerability Spectre v2: Mitigation; Retpolines, STIBP disabled, RSB filling, PBRSB-eIBRS Not affected
Vulnerability Srbds: Not affected
Vulnerability Tsx async abort: Mitigation; Clear CPU buffers; SMT Host state unknown

Cpu Property Value
Brand Intel(R) Xeon(R) Platinum 8272CL CPU @ 2.60GHz
Vendor :Intel
Architecture :Skylake
Model Family: 0x06, Model: 0x55, Stepping: 0x07, Type: 0x00
Cores 2 physical cores, 2 logical cores (on executing CPU)
No Hyperthreading hardware capability detected
Clock Frequencies Not supported by CPU
Data Cache Level 1:3 : (32, 1024, 36608) kbytes
64 byte cache line size
Address Size 48 bits virtual, 46 bits physical
SIMD 512 bit = 64 byte max. SIMD vector size
Time Stamp Counter TSC is accessible via rdtsc
TSC increased at every clock cycle (non-invariant TSC)
Perf. Monitoring Performance Monitoring Counters (PMC) are not supported
Hypervisor Yes, Microsoft

@aviatesk aviatesk merged commit 5247ef8 into master May 5, 2023
20 checks passed
@aviatesk aviatesk deleted the avi/bump-preferences branch May 5, 2023 09:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants