[MER-2347] No positional args. #153
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Current Aviator status
This PR was merged using Aviator. |
twavv
approved these changes
Jun 1, 2023
draftcode
reviewed
Jun 1, 2023
cmd/av/stack_sync.go
Outdated
| @@ -48,6 +48,7 @@ latest commit to the repository base branch (e.g., main or master) into the | |||
| stack. This is useful for rebasing a whole stack on the latest changes from the | |||
| base branch. | |||
| `), | |||
| PositionalArgs: cobra.NoArgs, | |||
There was a problem hiding this comment.
Yes, I had this locally and then pushed the wrong state. >.<
Rewriting history please hold.
draftcode
approved these changes
Jun 1, 2023
ErichKramer
force-pushed
the
stack_sync_no_pos
branch
from
a583a85
to
97cd1d8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Has no test code.
Arguably this warrants adding a test case that verifies we error on positional args to stack sync.
I looked at our e2e_tests for a bit and didn't have an immediate idea of where/ how to add this and I'm not yet familiar with gittest. Feel free to bounce back to me that this needs a testcase.