new call wrappers for limits, quota-sets, tenant-usage and hypervisors #89
Conversation
|
Thanks for your PR, @rochaporto! Before I accept this, can you add the tests alongside your code? |
|
Sure! Will do it next week. |
|
Awesome. Thanks a lot for your work! On Thursday, May 22, 2014, Ricardo Rocha notifications@github.com wrote:
|
adds the network service branch in openstack calls. also adds two initial calls for network/neutron: - floatingips (listing) - quotas (listing) both taking a tenant_id as a parameter.
|
@rochaporto You'll need to include the cassettes generated by your tests with your commit. Those are needed by the CI since it doesn't have access to a live OpenStack environment when it runs the tests. |
| link 'documentation', | ||
| 'http://api.openstack.org/api-ref-compute-v2.html#compute_limits' | ||
|
|
||
| param :tenant_id, required: false |
There was a problem hiding this comment.
required: false and other similar code need to be converted to the hashrocket style :required => false since the former does not work with Ruby 1.8. Personally, I'd rather use the newstyle but since other projects still need to use this library with Ruby 1.8 (e.g. Puppet), we need to accommodate them.
|
Ups sorry about that i didn't mean to push it all here. |
|
No worries @rochaporto. Let me know if you need help with this PR. I'd like to merge this soon. |
|
Hi @rochaporto. I'm going to close this PR in the meantime since these changes have diverged from the master branch. You will need to rebase your changes to master and resolve any conflicts. I did, however, cherry-pick one of your changes and merged to master in case you need a reference. The merged code is here: 97eff09 Again, thank you very much for your work! |
This pull request contains two commits for the functionality describe in the title.