[FEAT] Fineract Integration #7
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fynmanoj
reviewed
Jul 7, 2020
bpmns/fineract-test.bpmn
Outdated
| @@ -0,0 +1,190 @@ | |||
| <?xml version="1.0" encoding="UTF-8"?> | |||
There was a problem hiding this comment.
That is a test BPMN
fynmanoj
reviewed
Jul 7, 2020
| @@ -30,6 +31,17 @@ | |||
|
|
|||
| </properties> | |||
|
|
|||
| <repositories> | |||
There was a problem hiding this comment.
Might be important. It was put by DPC.
| @@ -39,27 +50,58 @@ public void configure() throws Exception { | |||
| logger.info("Access token: " + accessTokenStore.getAccessToken()); | |||
| }); | |||
|
|
|||
| from("rest:GET:/deploy") | |||
| .to("direct:test-bpmn") | |||
| from("rest:POST:/account/{accountAction}") | |||
There was a problem hiding this comment.
move these actions from the Health Check
| Map<String, Object> variables = new HashMap<>(); | ||
| variables.put("transactionId", generateUUID()); | ||
| variables.put("channelRequest", exchange.getIn().getBody(String.class)); | ||
| variables.put("tenantId", "tn05"); |
| variables.put("transactionId", generateUUID()); | ||
| variables.put("channelRequest", exchange.getIn().getBody(String.class)); | ||
| variables.put("tenantId", "tn05"); | ||
| zeebeProcessStarter.startZeebeWorkflow("fineract-test", variables); |
There was a problem hiding this comment.
remove hardcode
variables.put("tenantId", "tn05");
src/main/java/org/mifos/connector/gsma/identifier/IdentifierLookupRoutes.java
Outdated
Show resolved
Hide resolved
src/main/java/org/mifos/connector/gsma/identifier/IdentifierResponseProcessor.java
Outdated
Show resolved
Hide resolved
| @@ -51,10 +51,10 @@ public void setErrorParameters(List<ErrorParameter> errorParameters) { | |||
|
|
|||
| @Override | |||
| public String toString() { | |||
| return "AccountStatusError{" + | |||
| return "ErrorDTO{" + | |||
| "errorCategory='" + errorCategory + '\'' + | |||
There was a problem hiding this comment.
It is auto-generated by Intellij. How do you want it to be?
There was a problem hiding this comment.
if you dont find it useful or not using it anywhere remove it.. else rewrite the method with string builder to concatenate large number of strings
src/main/java/org/mifos/connector/gsma/transfer/TransferRoutes.java
Outdated
Show resolved
Hide resolved
| .setHeader("Content-Type", constant("application/json")) | ||
| .setBody(exchange -> exchange.getProperty(TRANSACTION_BODY)) | ||
| .marshal().json(JsonLibrary.Jackson) | ||
| .toD(BaseURL + "/transactions" + "?bridgeEndpoint=true&throwExceptionOnFailure=false"); |
There was a problem hiding this comment.
remove hardcode ; also concat is unnecessary
There was a problem hiding this comment.
So, the query part is for Camel to make the http call, it is not actually from GSMA API so I kept it separate.
src/main/java/org/mifos/connector/gsma/transfer/TransformRequestDataProcessor.java
Outdated
Show resolved
Hide resolved
fynmanoj
suggested changes
Jul 7, 2020
src/main/java/org/mifos/connector/gsma/transfer/TransferResponseProcessor.java
Outdated
Show resolved
Hide resolved
|
merge all the commits to single commit |
refactor: balance comment feat: basic implementation of transaction route feat: transaction error handling and correlation mapping feat: added checkAccountStatus worker and refactored account route feat: account message publisher dev: transfer workers dev: transfer workers - TBT transaction failing, generic error feat: end to end transaction on Zeebe added bpmns dev:common channel request DTO transform fix: fixed transaction issues changed deployment settings refactor: removed hardcoded values refactor: removed test APIs
SubhamPramanik
force-pushed
the
fineract-integration
branch
from
d653298
to
f63a6f4
Compare
…ector-gsma into fineract-integration
|
@SubhamPramanik - LGTM. Rebase and resolve conflicts please. |
…ctor-gsma into fineract-integration
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR consists of: