New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added finger counter #861
Added finger counter #861
Conversation
I need some help like confirmation if it is working as I got a sudden problem like stuck somewhere and messed up all! Can you please check from your side? @kaustubhgupta @santushtisharma10 Let me know if it's working well or else suggest me changes. I will go through that. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Minor change, else it worked at my end
Finger-Counter/finger_counter.py
Outdated
cap.set(3, wCam) | ||
cap.set(4, hCam) | ||
|
||
folderPath = "FingerImages" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
folderPath = "FingerImages" | |
folderPath = "./Finger-Counter/FingerImages" |
I will create a README.md file for this by tomorrow. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Create the readme for this
@kaustubhgupta @santushtisharma10 @antrikshmisri Kindly review this. |
Finger-Counter/README.md
Outdated
|
||
<br> | ||
|
||
### Hand tracking in real time |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
### Hand tracking in real time | |
## Hand tracking in real time |
Finger-Counter/README.md
Outdated
|
||
<br> | ||
|
||
### Finger counter |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
### Finger counter | |
## Finger counter |
@mehabhalodiya This code is exactly the same as this code on stackoverflow, unless it was asked by you. @kaustubhgupta @santushtisharma10 |
Hello @antrikshmisri , I wasn't also aware of which you have provided the link like it exists there. I understand your point. Since my Code looks too similar, you can suggest/tell for some changes. So that you can verify whether I understand things fully, by refactoring a few parts. This is my sincere request as I haven't copied from there. |
@antrikshmisri yes the code is way too similar. I think we should give @mehabhalodiya one more chance to improve upon the code as she has a good history of contributions (9 PRs merged: https://github.com/avinashkranjan/Amazing-Python-Scripts/pulls?q=is%3Apr+author%3Amehabhalodiya+is%3Aclosed) @santushtisharma10 @antrikshmisri should we give her the chance? |
You all mentors can suggest me changes in this script, I will do that as per your instructions. |
I agree, we should give her chance |
@kaustubhgupta Sure, we can her another chance based on her contributions. @mehabhalodiya Either restructure your code entirely or you can come up with some new features for it. |
Yes, thank you for understanding me. |
Kindly let me know if you want any changes because I myself don't know. |
If you feel that it's good to go then please inform me. |
Hi @mehabhalodiya, |
Finger-Counter/finger_counter.py
Outdated
cv2.imshow("Image", img) | ||
cv2.waitKey(1) | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
cv2.imshow("Image", img) | |
cv2.waitKey(1) | |
cv2.imshow("Image", img) | |
if cv2.waitKey(1) == ord('q') : | |
break | |
cv2.destroyAllWindows() |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@mehabhalodiya the script is working on my local system, just add these final changes.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for helping me wherever I got stuck :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@mehabhalodiya Add the requirements.txt file and update the PR template with project metadata. Look at this PR for reference: #1002
Update the PR template too |
Updated! |
Description
OpenCV
, along with some built-in modules of python liketime
andos
.Fixes #817
Finger counter using hand tracking
Have you read the Contributing Guidelines on Pull Requests?
Type of change
Checklist:
README.md
Template for README.md
Project Metadata
If there is no-file/nothing to fill the below fields with, then type: none
Example
: If no requirements.txt needed/present then type inRequirments
none =>Requirments: none
Category:
Title: Finger Counter using hand tracking
Folder: Finger-Counter
Requirements: requirements.txt
Script: finger_counter.py
Arguments: none
Contributor: mehabhalodiya
Description: A system that detects a human hand, segments the hand, counts the number of fingers being held up, and displays the finger count, from live video input.