Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added Base-N-Calc Files #1002

Merged
merged 2 commits into from
May 11, 2021
Merged

Added Base-N-Calc Files #1002

merged 2 commits into from
May 11, 2021

Conversation

XZANATOL
Copy link
Contributor

@XZANATOL XZANATOL commented May 1, 2021

Description

Added Base-N calculator.

Fixes #957

Have you read the Contributing Guidelines on Pull Requests?

  • Yes
  • No

Type of change

  • New feature (non-breaking change which adds functionality)
  • Documentation Update

Checklist:

  • My code follows the style guidelines(Clean Code) of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have created a helpful and easy to understand README.md
  • My documentation follows Template for README.md
  • I have added the project meta data in the PR template.
  • I have created the requirements.txt file if needed.

Project Metadata

If there is no-file/nothing to fill the below fields with, then type: none

Example: If no requirements.txt needed/present then type in Requirments none => Requirments: none

Category:

  • Calculators
  • AI/ML
  • Scrappers
  • Social_Media
  • PDF
  • Image_Processing
  • Video_Processing
  • Games
  • Networking
  • OS_Utilities
  • Automation
  • Cryptography
  • Computer_Vision
  • Fun
  • Others

Title: Base_N Calculator

Folder: Base-N_Calc

Requirements: none

Script: script.py

Arguments: none

Contributor: XZANATOL

Description: A GUI that will allow you to convert a number of base-X to base-Y as long as X&Y > 1.

Copy link
Contributor

@kaustubhgupta kaustubhgupta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a minor change:

# <----- GUI Code Beginning ----->
main_window = Tk()
main_window.title("Base-N Calculator")
Icon = PhotoImage(file="data/GSSOC.png")
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
Icon = PhotoImage(file="data/GSSOC.png")
Icon = PhotoImage(file="./Base-N_Calc/data/GSSOC.png")

@kaustubhgupta kaustubhgupta added the next review needed Approved by some mentors, more approvals needed label May 2, 2021
@XZANATOL
Copy link
Contributor Author

XZANATOL commented May 2, 2021

Done

Copy link

@Kushal997-das Kushal997-das left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 💯

Copy link
Contributor

@santushtisharma10 santushtisharma10 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@santushtisharma10 santushtisharma10 added Approved PR Approved and Ready to Merge gssoc23 Issues created for/by the GirlScript Summer of Code'23 Participants level2 Bug fixing, Adding small features and removed next review needed Approved by some mentors, more approvals needed labels May 5, 2021
@XZANATOL XZANATOL mentioned this pull request May 9, 2021
11 tasks
@kaustubhgupta kaustubhgupta merged commit 127ea4c into avinashkranjan:master May 11, 2021
@shantamsultania shantamsultania mentioned this pull request May 11, 2021
19 tasks
@albertzeap albertzeap mentioned this pull request May 12, 2021
29 tasks
@Shubhrima Shubhrima mentioned this pull request May 14, 2021
18 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Approved PR Approved and Ready to Merge gssoc23 Issues created for/by the GirlScript Summer of Code'23 Participants level2 Bug fixing, Adding small features
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Base-N Calculator
5 participants