Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

valPSNR increase very slowly #21

Closed
hogeman2 opened this issue Jan 11, 2019 · 9 comments
Closed

valPSNR increase very slowly #21

hogeman2 opened this issue Jan 11, 2019 · 9 comments
Labels
duplicate This issue or pull request already exists

Comments

@hogeman2
Copy link

hogeman2 commented Jan 11, 2019

Nice work thanks!

I have a question about convergence speed

I've run your training code and almost passed 50 epoch. The valPSNR is still under 15.5.

Is that normal?

also created clips seems to be not sequencial is that ok?

@avinashpaliwal
Copy link
Owner

  • I have added tensorboard. How do the interpolated images look on the validation set?

  • Are you using a custom dataset or adobe240fps dataset?

    • If you are using a custom dataset, then it should have slow motion videos. The dataloader takes frame1 and frame8 as reference and interpolates the frames in between.
  • Did you use the create_dataset script?

@hogeman2
Copy link
Author

Thanks for your reply
First interpolated images looks not good and blurred.

And I used adobe240dataset using create_dataset script

@avinashpaliwal
Copy link
Owner

Can you attach the interpolated results from tensorboard? Also specify your setup- CPU/GPU, PyTorch version, OS, etc. 15.5 valPSNR is really low. Maybe there is a problem with dataset or setup.

@hogeman2
Copy link
Author

I'm using GTX 1060
Is that problem reducing batch size to 4?

screenshot from 2019-01-16 11-50-48
screenshot from 2019-01-16 11-51-37

I added validation image, and graph

@hogeman2
Copy link
Author

#22
seems like this was the problem
I've changed code and graph looks good.

@avinashpaliwal
Copy link
Owner

avinashpaliwal commented Jan 16, 2019

#22
seems like this was the problem
I've changed code and graph looks good.

Right. The two reference (left and right corner) look very different. Frames in a clip look very similar since they are slow motion videos. Will fix the code.

@avinashpaliwal avinashpaliwal added the duplicate This issue or pull request already exists label Jan 16, 2019
@hogeman2
Copy link
Author

@avinashpaliwal line 69 in create_dataset.py.
I changed line
images = os.listdir(os.path.join(root, file))
to
images = sorted(os.listdir(os.path.join(root, file)))

@shliang0603
Copy link

shliang0603 commented Mar 4, 2019

@avinashpaliwal I have the same problem. I had trained the model to 270 epoch, but the valPSNR keep bellow 15, can you help me ?
image

the follow is valPSNR changing curve
image

avinashpaliwal added a commit that referenced this issue Mar 4, 2019
Fixed issues as per suggestions.
@avinashpaliwal
Copy link
Owner

@avinashpaliwal I have the same problem. I had trained the model to 270 epoch, but the valPSNR keep bellow 15, can you help me ?
image

the follow is valPSNR changing curve
image

Try the new create_dataset script to generate the dataset and try training again. The model starts converging right from the beginning.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
duplicate This issue or pull request already exists
Projects
None yet
Development

No branches or pull requests

3 participants