Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

About preparing training data #22

Closed
ChenxiTU opened this issue Jan 15, 2019 · 5 comments
Closed

About preparing training data #22

ChenxiTU opened this issue Jan 15, 2019 · 5 comments
Assignees
Labels
bug Something isn't working
Projects

Comments

@ChenxiTU
Copy link

Thank you for sharing your nice work!

I used create_dataset.py to build the training dataset as you mentioned. But I find that 12 frames in each clip is not continuous.

Maybe L.69 in create_dataset.py should be modified:
images = os.listdir(os.path.join(root, file)) -> images = sorted(os.listdir(os.path.join(root, file)))

Or I misunderstood, the frame in each clip should not be continuous?

@avinashpaliwal
Copy link
Owner

The frames inside a clip (folder) should be continuous. The clips can be in different order which doesn't affect the training because the network only looks at the frames from one particular clip. There is no need for sorted and it actually doesn't work because 11 is taken before 2. I have added zero padding using `%04d' here so that frames are named 0001.jpg, 0002.jpg and so on. But if you have more than 9999 frames, you'll have to increase the zero padding.

@ChenxiTU
Copy link
Author

Thank you for your quickly reply. According to what you said, I think my understand is right.

What I'd like to say is that the frames inside a clip is not continuous when I used create_dataset.py.
For example, in adobe240/train/0/, I got 12 frames like this: 0257.jpg, 0438.jpg, 1116.jpg ... which are not continuous.
If I add sorted(), in adobe240/train/0/, I got 12 frames: 0001.jpg, 0002.jpg, 0003.jpg ... 0012.jpg
I think sorted() can work because after extracted from video, frames' names are already padded.

Maybe different operating system has different result. In may case, I use ubuntu 16.04.

Sorry in advance, if I still misunderstand something.

@avinashpaliwal
Copy link
Owner

Thank you for your quickly reply. According to what you said, I think my understand is right.

What I'd like to say is that the frames inside a clip is not continuous when I used create_dataset.py.
For example, in adobe240/train/0/, I got 12 frames like this: 0257.jpg, 0438.jpg, 1116.jpg ... which are not continuous.
If I add sorted(), in adobe240/train/0/, I got 12 frames: 0001.jpg, 0002.jpg, 0003.jpg ... 0012.jpg
I think sorted() can work because after extracted from video, frames' names are already padded.

Maybe different operating system has different result. In may case, I use ubuntu 16.04.

Sorry in advance, if I still misunderstand something.

Ohh. I haven't tested it on Linux OSes yet. Thanks for pointing out the bug.

@avinashpaliwal avinashpaliwal self-assigned this Jan 16, 2019
@avinashpaliwal avinashpaliwal added the bug Something isn't working label Jan 16, 2019
@avinashpaliwal avinashpaliwal added this to To do in Super SloMo via automation Jan 16, 2019
@tingxueronghua
Copy link

Hey, I want to know whether the images in one folder are really continues, or I just need to change the images' name by myself? The checkpoint trained by myself works really terrible, and is there anything to do with this bug?

avinashpaliwal added a commit that referenced this issue Mar 4, 2019
Fixed issues as per suggestions.
@avinashpaliwal
Copy link
Owner

Hey, I want to know whether the images in one folder are really continues, or I just need to change the images' name by myself? The checkpoint trained by myself works really terrible, and is there anything to do with this bug?

Yes. The images inside 'clips' folders which contains 12 images should be continuous. If they are not, that would mess up the training. I have updated the dataset generation script. Try running it again to generate the whole dataset.

Super SloMo automation moved this from To do to Done Mar 4, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Super SloMo
  
Done
Development

No branches or pull requests

3 participants