Update lock files to fix aarch64 compatibility #6
Conversation
|
Thanks! Can you signoff your commits please? |
Signed-off-by: Matt Hooks <mhooks@rippling.com>
Hooksie
force-pushed
the
update-lock-files
branch
from
55b0d30
to
05f9365
Compare
|
@aviramha Certainly, all set BTW, I dont have the manylinux env setup on this dev machine, and so I havent tested the release builds with these new lockfiles on anything aside from an M1 Macbook. I'm assuming the CI on this project will handle that? |
|
Crap, 3.6 reached EOL - can you remove it as part of this PR please? |
Removes flags no longer supported by maturin (--sdist), in favor of the new default behavior. Also extends the release_macos job to use matrix for build target arch for future wheel cross-compilation. Also swap the rust toolchain to stable, since nightly is not needed here. Signed-off-by: Matt Hooks <mhooks@rippling.com>
|
@aviramha Went ahead and pulled those out, and extended out the github actions as well to include the latest Python versions. I did poke around a bit at cross-compiling the M1 wheel, but ultimately chose not to, wanting to avoid the work of pulling in new openssl steps for alternative targets. I moved the target to a matrix in macos though, so it will be easy drop in for the future. maturin removed |
|
Thanks! I appreciate the work you did. I'd like to offer you to join as a maintainer as it seems you have stake & interest (atleast more than I do at the moment). |
|
@aviramha Thanks! (and apologies for delay, I've been on vacation 🙂 ) I'd be happy to continue helping, although notably I don't think I'll have a guaranteed time commitment. In the meantime, I'd be happy to drop a few more maintenance patches in, if it's not a burden |
|
Sure! There's no time commitment from my side as well - It seems ormsgpack is already being used by quite few companies, and I don't want to be single point of failure for changes :) |
Updates lock files and associated toml configs for latest maturin version, since current values are no longer compatible with the latest versions. Also bump the min python version
Since this changes compatibility for Python version, it's technically backwards incompatible. But given the project is
<1.0, IIRC semver doesnt require a major version bump, so I'll leave it at0.3.Fixes #5