Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Exclude android / ios build artifacts from NPM module #210

Merged
merged 2 commits into from
Jan 28, 2023

Conversation

TikiTDO
Copy link
Contributor

@TikiTDO TikiTDO commented Jun 8, 2022

The lib is currently pulled with intermediate build artifacts, which get automatically replaced when an app is started. It should be safe to exclude these from the package.

The lib is currently pulled with intermediate build artifacts, which get automatically replace when an app is started. It should be safe to exclude these from the package.
Copy link

@Derewith Derewith left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems great!

Copy link

@todorone todorone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@avishayil
Copy link
Owner

Thanks @TikiTDO , good catch!

@avishayil avishayil merged commit 3ecc9c9 into avishayil:master Jan 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants