Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

centralised migration orchestration - directly publishing to leader project #56

Merged

Conversation

YabMas
Copy link
Contributor

@YabMas YabMas commented Jan 16, 2024

This PR is part of the effort to make one region leader of the dare-migrations for all regions an app operates in (as opposed to each region orchestrating the migrations away from it).

I would have preferred to solve this on the infrastructure level. But it's surprisingly hard to forward a message from one topic to another. Not impossible, but the needed setup/resources are either unnecessarily elaborate or expensive.

So solving it in the application code isn't the most pretty but it works, so fine.

We could make the migration leader configurable in the future, but really why?

Copy link
Contributor

@Zatura24 Zatura24 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If I understand correctly you are now generating topics with different depending on the stage as well. Doesn't this lead to many topics for which you have to subscribe to them all?

@YabMas
Copy link
Contributor Author

YabMas commented Jan 16, 2024

Stage is: test or production, so no there aren't that many topics. Maybe not the clearest var-name, wasn't sure about it but ended up going with this instead of env because that's already used a lot in our codebases with a different meaning.

@Zatura24
Copy link
Contributor

Stage is: test or production, so no there aren't that many topics. Maybe not the clearest var-name, wasn't sure about it but ended up going with this instead of env because that's already used a lot in our codebases with a different meaning.

I see, if it isn't to much of a burden a more verbose environment might be better to understand in this case

@YabMas YabMas force-pushed the feature/55-publish-migration-message-to-leader-project branch from 6b5efa2 to 9c4a393 Compare January 16, 2024 15:53
@YabMas YabMas force-pushed the feature/55-publish-migration-message-to-leader-project branch from 9c4a393 to cc552fc Compare January 16, 2024 15:54
@YabMas
Copy link
Contributor Author

YabMas commented Jan 16, 2024

Sure, made the change.

@YabMas YabMas merged commit 77b36d5 into master Jan 16, 2024
5 of 6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants