Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add favicon and logo documentation #176

Closed
wants to merge 5 commits into from

Conversation

Zaijo
Copy link
Contributor

@Zaijo Zaijo commented Mar 13, 2023

Add documentation for #135

@Zaijo
Copy link
Contributor Author

Zaijo commented Mar 13, 2023

@jp7677 can you please correct the documentation so it documents real steps?

@Zaijo
Copy link
Contributor Author

Zaijo commented Mar 13, 2023

It's ready from my side. Working for me as documented.

@Zaijo Zaijo changed the title Add favicon documentation Add favicon and logo documentation Mar 13, 2023
@jp7677
Copy link
Collaborator

jp7677 commented Mar 15, 2023

Thanks a lot for taking the initiative. Would you mind expanding the documentation to include all the branding properties? I think it is also a good idea to start with an introduction and a table showing the separate properties and its meanings.

@Zaijo
Copy link
Contributor Author

Zaijo commented Mar 16, 2023

I'm not aware of any other options. Do you have some link with details? On the other hand, this is quite the maximum I'm able to offer these days.

@jp7677
Copy link
Collaborator

jp7677 commented Mar 16, 2023

The other two options are the primary and secondary colors, next to the properties that Structurizr itself offers for the C4-Plantuml exporter.
See https://github.com/avisi-cloud/structurizr-site-generatr/blob/main/docs/example/workspace.dsl#L159 and https://github.com/structurizr/export/tree/main/src/main/java/com/structurizr/export/plantuml#c4plantumlexporter

@Zaijo
Copy link
Contributor Author

Zaijo commented Mar 17, 2023

Sorry, no more time on my side.

@jp7677
Copy link
Collaborator

jp7677 commented Apr 19, 2023

Superseded by #206

@jp7677 jp7677 closed this Apr 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants