Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

introduce additional port parameter (-p port_number) for serve command #212

Merged
merged 2 commits into from
Apr 26, 2023

Conversation

UBessle
Copy link
Contributor

@UBessle UBessle commented Apr 23, 2023

Typically i have many things running, that would like to use port 8080. So perhaps it's helpfull for others as well, if they could configure the port used by the serve command

@jp7677
Copy link
Collaborator

jp7677 commented Apr 24, 2023

Could you please also modify the readme at https://github.com/avisi-cloud/structurizr-site-generatr/blob/main/README.md#start-a-development-web-server-around-the-generated-website and note that 8080 is the default port.

Otherwise, LGTM!

@UBessle
Copy link
Contributor Author

UBessle commented Apr 26, 2023

build-docker failed to download ubuntu packages during Dockerfile command
RUN apt update && apt install graphviz --yes && rm -rf /var/lib/apt/lists/*

gh run view 4805742224 --log-failed shows, that some ubuntu repository server can't be reached
build-docker Build container image 2023-04-26T07:01:25.2641543Z #9 70.75 W: Failed to fetch http://ports.ubuntu.com/ubuntu-ports/dists/jammy-backports/InRelease Unable to connect to ports.ubuntu.com:80: [IP: 185.125.190.39 80]

Looks like a problem, that is not related to the content of the pull request

@jp7677 jp7677 self-requested a review April 26, 2023 09:31
Copy link
Collaborator

@jp7677 jp7677 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved.

Please be careful with changes unrelated to the goal of a PR, in this case the additional readme formatting. Usually it works better to leave unrelated things untouched (even if they are not perfect) or to open a separate PR.
Additionally https://cbea.ms/git-commit/ might be a good read to improve your commit messages.

@jp7677 jp7677 merged commit 8a0db33 into avisi-cloud:main Apr 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants