Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Print exception stack trace for bad branch #287

Merged
merged 3 commits into from
Aug 31, 2023

Conversation

pietermees
Copy link
Contributor

Print stack trace to help debug bad branches. Will help resolve #286.

@qtzar
Copy link
Contributor

qtzar commented Aug 16, 2023

Good idea. I ran in to a similar issue the other day myself but fortunately I was able to pull the branch locally and see the error when doing a serve.

Instead of the full stack trace I wonder if it would be better to extract just the cause and print that to the tty.

@pietermees
Copy link
Contributor Author

Maybe something like the following?

errorMessage = e.message ?: "Unknown error"
println("Bad Branch $branch: $errorMessage")

Only print error message, not full stack trace
@pietermees
Copy link
Contributor Author

I've updated the PR to only print the error message

…eCommand.kt

Co-authored-by: Dirk Groot <dirkgroot77@gmail.com>
@dirkgroot dirkgroot merged commit 3c5f7b6 into avisi-cloud:main Aug 31, 2023
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Vague error message on bad branch
3 participants