Asciidoc support #336
Merged
Asciidoc support #336
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
jp7677
force-pushed
the
asciidoc-support
branch
2 times, most recently
from
b571a9a
to
f306904
Compare
Closed
jp7677
force-pushed
the
asciidoc-support
branch
from
b72f3e0
to
d97ed7d
Compare
No search support yet... Co-authored-by: Fabian Illner <fabian@illner.dev>
Co-authored-by: Fabian Illner <fabian@illner.dev>
This makes AsciiDoc content searchable. Also simplify document title extraction. Don't try to make up a title if there is no title. Co-authored-by: Fabian Illner <fabian@illner.dev>
It's much cheaper to reuse an already created instance. Co-authored-by: Fabian Illner <fabian@illner.dev>
Co-authored-by: Fabian Illner <fabian@illner.dev>
Also improve formatting. Co-authored-by: Fabian Illner <fabian@illner.dev>
jp7677
force-pushed
the
asciidoc-support
branch
from
d97ed7d
to
45efb9b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on #307
It does the job, but performance isn't great yet.Also not sure yet about the JRuby requirement.