fix: ending slash are preserved on links #543
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Is this the same as #534 ? |
|
Oh, wow looks like this is the same. I didn't look if anyone else tried to solve this. I think you can close my PR. |
Or the other way around ;). Could you please check if my version also fixes your issue? |
|
@jp7677 will do it today. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When creating in Markdown links they are being stripped of ending slash
/. This creates sometimes an issues for redirects. To solve this resolver takes into account if in original link it was slash ending and make sure that after relative URL generation that slash is being preserved.