-
Notifications
You must be signed in to change notification settings - Fork 31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for software system properties #79
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This cell type can represent simple links to external sites.
Show properties as table on the software systems home page. Render properties containing an URL as simple link.
jp7677
force-pushed
the
software-system-properties
branch
from
October 31, 2022 13:14
59a7b23
to
11e775a
Compare
dirkgroot
reviewed
Nov 2, 2022
src/main/kotlin/nl/avisi/structurizr/site/generatr/site/model/PropertiesTableViewModel.kt
Outdated
Show resolved
Hide resolved
We should need to configure the standard exporter for that. Also put createStructurizrWorkspace into a separate file since it's doing more now than just parsing the dsl file.
jp7677
force-pushed
the
software-system-properties
branch
from
November 2, 2022 09:32
11e775a
to
7d5e4ae
Compare
Looks good, thanks! |
jp7677
added a commit
to jp7677/structurizr-site-generatr
that referenced
this pull request
Nov 11, 2022
No need to hardcode this in code once you know how to set this property in the dsl file. This is a left-over from avisi-cloud#79
jp7677
added a commit
to jp7677/structurizr-site-generatr
that referenced
this pull request
Nov 11, 2022
No need to hardcode this in code once you know how to set this property in the dsl file. This is a left-over from avisi-cloud#79
jp7677
added a commit
to jp7677/structurizr-site-generatr
that referenced
this pull request
Nov 11, 2022
No need to hardcode this in code once you know how to set this property in the dsl file. This is a left-over from avisi-cloud#79
jp7677
added a commit
to jp7677/structurizr-site-generatr
that referenced
this pull request
Nov 15, 2022
No need to hardcode this in code once you know how to set this property in the dsl file. This is a left-over from avisi-cloud#79
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Show properties as table on the software systems home page and in the generated diagrams.
Properties containing an URL will be rendered as simple link on the software systems home.
The generated diagrams will also show properties on other elements, e.g. persons.