Streamline diagram presentation in markdowns #95
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
About https://github.com/avisi-cloud/structurizr-site-generatr/blob/main/src/main/kotlin/nl/avisi/structurizr/site/generatr/site/views/Markdown.kt#L25 , we might wanna move the markdown translation to the model and just pass the resulting html to the view. Edit: this is now done as part of this PR. |
Re-use the diagram view when rendering an embedded diagram in a markdown. Also handle non-existing diagram keys in markdowns.
Without doing so we end up with a full html document including header and body, but here we only need the inner html of the body.
This is more in line with the handling of raw html for SVG files and simplifies the views.
jp7677
force-pushed
the
markdown-diagrams
branch
from
e21f4d5
to
4467131
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Re-use the diagram view when rendering an embedded diagram in a markdown.
Also handle non-existing diagram keys in markdowns. This fixes #93