-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature request: add rate #37
Comments
We think about adding lua for processing metrics before they are sent to carbon. It should solve most of the post-aggregation problems better than single cases |
msaf1980@046382e |
You can use a lazy_static to stay safe. |
@Albibek Firstly, modern statsd sends Secondly, such metrics highly rely on an interval of aggregation (that defaults to 10s), and it can be tricky to implement rate calculation based on total count only. Could you explain how you use graphite functions to do it? We use mhr3/brubeck (supports
We write in rust and want to replace brubeck with bioyino, but the absence of |
Considering your request is another one here, I think this can and should be implemented. Also, some time ago I was worrying about increasing the number of unique names for ms, but since 0.7 (not yet released) it's possible to define aggregations in config, so this is not a problem. |
@loyd @msaf1980 The rate aggregation has been added into 0.8.0-alpha2 tag Note, that it is available for all metrics, because of the update counter value being used. So for i.e. set or counter the rate is also available, but for set it will not always be equal to Could be great if you tested this somewhere so I am sure it works as intended. |
Add
rate as sum / (carbon.interval / 1000)
sample_rate as agg.len() / (carbon.interval / 1000)
The text was updated successfully, but these errors were encountered: