-
-
Notifications
You must be signed in to change notification settings - Fork 144
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat/slash command #145
Feat/slash command #145
Conversation
🦋 Changeset detectedLatest commit: f85de60 The changes in this PR will be included in the next version bump. Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Deployment failed with the following error:
|
Deployment failed with the following error:
|
438d5f2
to
bbd42d1
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey Andre,
once again, the slash command is a really nice feature.
The problem with it at the moment is that using the keyboard to access the add image url option does not work. Pressing "Enter" on "Image from URL" does not work from the first try. It seems like pressing arrow down, or up, will cycle through the original list of commands rather than the two commands "Image Upload" and "Image from URL".
Also, onKeyDown property in the "button" element (see ImageCommandList) is never triggered. The onKeyDown function is scoped inside of useEffect, so you cannot use it outside of the scope. And speaking of useEffect, the if conditions for "Enter" is not triggered in SlashCommand for normal commands inspite of the commands working.
I have tested this with the Brave browser (similar to chrome) and Firefox. Both have the same problem.
I am providing you with a video showing how to reproduce the problem. You have to press arrow down for about 10 times to actually have the Image URL tab work. If you press down twice, ending up back in Image Upload, and press enter, image upload wont work because you cycled to the next item (one of the normal commands outside of the Image command).
outstatic-slash-command-bug.mp4
@ZiyadBoshima I think this is fixed with the last commit. Thank you so much for going over this. I was testing the slash command option by typing /image and that seemed to work properly. The new commit takes care of the issue you were facing and also adds "Esc" support to go back to the main slash command menu. I still need to update our documentation to use the slash command. |
f6c6d32
to
6f227a8
Compare
Bug
fixes #number
contributing.md
Feature
fixes #number