Allow to set redirect_uri when logging-in thru GitHub (uses OST_GITHUB_CALLBACK_URL)

[spidgorny]

Add NEXT_PUBLIC_APP_URL env

Bug

• Related issues linked using fixes #number
• Integration tests added
• Errors have a helpful link attached, see contributing.md

Feature

• Implements an existing feature request or RFC. Make sure the feature request has been accepted for implementation before opening a PR.
• Related issues linked using fixes #number
• Integration tests added
• Documentation added

[changeset-bot]

🦋 Changeset detected

Latest commit: f3ac05c

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

[vercel]

Someone is attempting to deploy a commit to a Personal Account owned by @avitorio on Vercel.

@avitorio first needs to authorize it.

[avitorio]

Hey @spidgorny, thanks for the PR!

I'll review it soon.

Would this redirect users to the homepage instead of the dashboard?

Can you elaborate a bit about the use case for this? Thanks!

[spidgorny]

I have setup a GitHub OAuth authorization. I needed to enter the production redirect_uri during the registration. It works fine in production.
But I could not login on localhost:3000, the GitHub login button would redirect me back to production.
By providing a custom redirect_uri from the .env file on localhost, I've tried to login thru GitHub and make it redirect back to localhost.
It looked like it was working, but later I had to create a completely separate OAuth app just for localhost. This PR may not be that useful in my particular case, but it's a nice feature anyway (if only GitHub supported redirecting to localhost).
Otherwise, just reject it.

[avitorio]

Hi @spidgorny , thanks for the explanation.

Yes, it is indeed annoying that we would need multiple OAuth Apps for different environments.

Apparently GitHub Apps can have multiple callbacks but not OAuth Apps.
We have setup instructions for Github Apps here: https://outstatic.com/docs/github-apps-authentication

It might be the case that your PR is not completely off. We'd need to test with GitHub Apps.

The only thing I'd change is, I'd probably pick a different name for the env var, probably something more explicit like:

OST_GITHUB_CALLBACK_URL

As we need to redirect back to http://localhost:3000/api/outstatic/callback for example, and not to just http://localhost:3000.

Do you want to give this a shot?

[vercel]

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
outstatic-dev-blog	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Nov 26, 2023 10:25pm
outstatic-web	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Nov 26, 2023 10:25pm

[avitorio]

@spidgorny Excellent job! Thank you so much for this feature.

[avitorio]

LGTM