Upgrade to XC 9.3.0 #28
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vincent-aviva
requested changes
Mar 12, 2020
Comment on lines
+6
to
+7
| SQL_SA_PASSWORD=8Tombs-Given-Clock#-arming-Alva-debut-Spine-monica-Normal-Ted-About1-chard-Easily-granddad-5Context! | ||
| TELERIK_ENCRYPTION_KEY=qspJhcSmT5VQSfbZadFfzhCK6Ud7uRoS42Qcm8UofvVLiXciUBcUeZELsTo8KD9o6KderQr9Z8uZ9CHisFJNRz46WTZ5qCRufRFt |
There was a problem hiding this comment.
Moeten deze 2 waardes hier wel staan? Qua naam lijkt me iig van niet.
There was a problem hiding this comment.
Is hetzelfde als het community Sitecore Docker setup: https://github.com/Sitecore/docker-images/blob/master/windows/tests/9.3.x/.env
| @@ -286,27 +286,25 @@ Nyxie.Serialization --> \build\website | |||
| Sitecore.Commerce.Engine --> \build\commerce | |||
|
|
|||
| - Build Sitecore XC Docker images according to the instructions found here: https://github.com/Sitecore/docker-images | |||
| - Or if you have pre-built Docker images available in a registry, set the `REGISTRY` in (./env) | |||
|
|
|||
| - Copy your Sitecore license file (license.xml) to the [](./license) folder | |||
There was a problem hiding this comment.
Hoezo is deze regel eruit gehaald? De license is toch nog steeds nodig?
There was a problem hiding this comment.
Licensing gebruik is aangepast in community Docker repo. Heb het hierin explicieter gemaakt.
vincent-aviva
approved these changes
Mar 12, 2020
Jonne
approved these changes
Mar 24, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.