Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for Icon and Theme Types #540

Closed
tayambamwanza opened this issue Jul 11, 2021 · 2 comments · Fixed by #541
Closed

Support for Icon and Theme Types #540

tayambamwanza opened this issue Jul 11, 2021 · 2 comments · Fixed by #541

Comments

@tayambamwanza
Copy link
Contributor

tayambamwanza commented Jul 11, 2021

This is for an optional feature that can be supported because of Angulars 'fullTemplateTypeCheck' mode, which provides enhanced autocomplete features for type safety in the html templates.

Earlier I submitted an issue for using optional Enums, which were helpful in narrowing down what options where available and avoiding typos, the downside is that one would have to import the enums and assign them to a variable to make use of them

i.e

iconEnums = IconEnums

My proposal is to add support for a custom IconName Type

i.e

export type IconName

and allow it as an optional input type.

The benefit will be that the user will not need to import and assign anything anymore, angular language service should autocomplete from a list of specified strings if fullTemplateTypeCheck is enabled.

By adding this feature as an option, current users will not need to do any migration work.

I am willing to do the pull request for this.

@avmaisak
Copy link
Owner

@tayambamwanza it will be great! I will bi waitng for PR

@tayambamwanza
Copy link
Contributor Author

#541

@avmaisak avmaisak linked a pull request Jul 12, 2021 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants