Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

User update does not update audit information #706

Open
Tracked by #1557
vinayvenu opened this issue Apr 2, 2024 · 7 comments · Fixed by #728
Open
Tracked by #1557

User update does not update audit information #706

vinayvenu opened this issue Apr 2, 2024 · 7 comments · Fixed by #728

Comments

@vinayvenu
Copy link
Member

vinayvenu commented Apr 2, 2024

The regular audit mechanism for all transactions in Avni does not work with the User domain object. As a result, all changes require us to manually set the user who updates a user. This currently does not happen for the following.

  1. PUT /user/{id}
  2. DELETE /user/{id}
  3. PUT /user/{id}/disable
  4. PUT /user/accountOrgAdmin/{id}/disable

There is a User.setAuditInfo that will need to be called in all these scenarios

@Dashlet26
Copy link

Whats the issue in this ........ like how to update User.setAuditInfo to make changes for the above following or something else

@vinayvenu
Copy link
Member Author

@Dashlet26 didn't understand your concern.

@Dashlet26
Copy link

Whats the issue in this

@vinayvenu
Copy link
Member Author

Try any of the urls mentioned in the issue, and you will notice that last_modified_by_id and last_modified_by columns on the users table are not modified. They need to be updated in all these scenarios.

If this is not clear, please join https://join.skype.com/xiTU162DSJTd so we can understand your concern.

@MiirzaBaig
Copy link

@vinayvenu Would like to work on this bug, if needed we can join a call for understanding the bug in depth...

ombhardwajj added a commit to ombhardwajj/avni-server that referenced this issue May 11, 2024
@ombhardwajj
Copy link
Contributor

@vinayvenu , I've tried to fix this issue . Could you please review the changes? Please let me know If any further adjustments are needed!!

ombhardwajj@64df265

ombhardwajj added a commit to ombhardwajj/avni-server that referenced this issue May 13, 2024
@vinayvenu
Copy link
Member Author

@ombhardwajj can you please raise a PR?

vinayvenu added a commit that referenced this issue May 14, 2024
@vinayvenu vinayvenu reopened this May 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: QA Ready
Development

Successfully merging a pull request may close this issue.

5 participants