Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

App Designer - Numeric Concept Low absolute value not shown properly after save #1000

Closed
AchalaBelokar opened this issue Jul 11, 2023 · 4 comments
Assignees
Labels
bug Something isn't working

Comments

@AchalaBelokar
Copy link

AchalaBelokar commented Jul 11, 2023

Describe the bug
In the web app the if numeric value we enter 0(zero) it show after saving N.A
Because of this suppose I set the low absolute value 0 , then I am able to enter the negative value also.

To Reproduce
Steps to reproduce the behavior:

  1. Create one Numeric concept
  2. Set low absolute value 0
  3. save
  4. After saving this it convert in to NA
    Expected behavior
    A clear and concise description of what you expected to happen.

Screenshots

Screen.Recording.2023-07-11.at.7.36.50.PM.mov

This will affect the
avniproject/avni-client#1049

@AchalaBelokar AchalaBelokar added the bug Something isn't working label Jul 11, 2023
@1t5j0y 1t5j0y self-assigned this Jul 12, 2023
@1t5j0y 1t5j0y changed the title In the web app the if numeric value we enter 0(zero) it show after saving N.A App Designer - Numeric Concept Low absolute value not saved properly Jul 12, 2023
@1t5j0y
Copy link
Contributor

1t5j0y commented Jul 12, 2023

This was a display only issue. The actual low absolute (and other attribute) values were getting saved correctly.

@1t5j0y 1t5j0y changed the title App Designer - Numeric Concept Low absolute value not saved properly App Designer - Numeric Concept Low absolute value not shown properly after save Jul 12, 2023
@AchalaBelokar
Copy link
Author

  • need to change value here also

Image

@vinayvenu
Copy link
Member

@AchalaBelokar @1t5j0y lets discuss in person today. This needs to be fixed in a patch only if it is causing trouble in data. My understanding is that negative values are being allowed even with a 0 absolute value.

@1t5j0y
Copy link
Contributor

1t5j0y commented Jul 17, 2023

Fixed display issue on inline concept display as well.
Moved code to master since this was moved to release 4.0.0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Archived in project
Development

No branches or pull requests

3 participants