Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DEA] Add support to input values for question group - repeatable and non-repeatable #1137

Closed
Tracked by #1507
mahalakshme opened this issue Feb 16, 2024 · 2 comments
Assignees

Comments

@mahalakshme
Copy link
Contributor

mahalakshme commented Feb 16, 2024

Need:

Sometimes admins want to edit some data entered by other users. And since admins are using master catchment, using mobile app to do the same via sync will be more time consuming. Hence they prefer to do it via DEA. Currently this is not possible for organisations whose forms use question group(repeatable or non-repeatable) since currently DEA doesn't support input for question group concepts(repeatable or non-repeatable).

Acceptance criteria:

  • Being able to take input for concepts within question group(QG).
  • For RQG, Ability to add more groups using + add button.
  • For RQG, Ability to remove groups using the - button.
  • For RQG, When the 'Disable addition or removal' is enabled, + and - buttons should not be displayed.
  • Being able to edit for all the above scenarios
  • In Summary and Recommendations page as well, observations need to display page wise supporting RQG. The UI design part, will already be done as part of this card. I think we just need to use the same component to display observations here if not done.

Mockups:

  1. In mobile app currently, we are changing the UI based on the data types of the form elements within the question group. Lets say them as Linear type and Box type. Unlike two different ways in mobile app, in DEA we can just have one way - linear type without using the box type considering webapp will be used on a larger display.

Linear type when coded data type present:
Screenshot 2024-02-16 at 2 13 29 PM

Box type when coded data type not present:
Screenshot 2024-02-16 at 2 12 41 PM

  1. For RQG, Video and mockups regarding when to enable and disable + and - buttons. Also note that we need to display the question group concept name.
    Video link: https://github.com/avniproject/avni-webapp/assets/10369963/adb96697-f886-412b-947e-f98077bc175a
    Image

  2. For RQG, When 'manual addition and removal' disabled, + and - icons should not be displayed like in the mobile:

Screenshot 2024-02-16 at 2 59 17 PM
  1. Also For question group which is not repeatable, + and - icons should not be displayed like in mobile:
    Image

  2. Summary and Recommendations page current reality(left) Vs expectation(mobile)
    Image

Out of scope:

  • Form element, form element group rules, decision rule and visit schedule rules(currently supported in DEA) need to execute as expected on form elements within RQG and QG
  • Supporting subject concept type within RQG

Suggestions:

  • we can potentially move decision and visit schedule rules as a different card
  • subject support - sync concept values - confirm - based on minor/major - validation
  • sync concept value - drop down/radio group - webapp?
  • can be supported - DEA complementary to mobile
@mahalakshme mahalakshme changed the title [DEA] Edit RQG [DEA] Add support to input values for question group - repeatable and non-repeatable Feb 16, 2024
@petmongrels petmongrels self-assigned this Mar 13, 2024
@petmongrels petmongrels self-assigned this Mar 22, 2024
petmongrels added a commit to avniproject/avni-server that referenced this issue Mar 22, 2024
petmongrels added a commit to avniproject/avni-models that referenced this issue Mar 28, 2024
petmongrels added a commit that referenced this issue Mar 28, 2024
petmongrels added a commit that referenced this issue Apr 2, 2024
petmongrels added a commit that referenced this issue Apr 3, 2024
petmongrels added a commit to avniproject/avni-models that referenced this issue Apr 5, 2024
petmongrels added a commit that referenced this issue Apr 5, 2024
…a flow of QG observations. basic change rule service to support RQG like avni client.
petmongrels added a commit that referenced this issue Apr 8, 2024
petmongrels added a commit to avniproject/avni-models that referenced this issue Apr 8, 2024
@petmongrels
Copy link
Contributor

  • For testing, it may be better to wait for the rules stories to complete as well - since they are not working correctly. I tested by disabling FormElementStatus rules. Without rules working doing QA on existing implementations may be misleading.

petmongrels added a commit that referenced this issue Apr 8, 2024
@mahalakshme
Copy link
Contributor Author

@petmongrels @AchalaBelokar just mentioning whatever discussed in standup:

  • I am creating cards adhering to INVEST principles, such that every card can be independently tested. From that perspective, @AchalaBelokar you can make sure cases around the ACs mentioned, works as expected. I am also hoping you are aware where what rules are employed. So I don't think testing this card should be a problem.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

No branches or pull requests

3 participants