Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Increase the export size #1142

Closed
Tracked by #1557
mahalakshme opened this issue Feb 28, 2024 · 2 comments
Closed
Tracked by #1557

Increase the export size #1142

mahalakshme opened this issue Feb 28, 2024 · 2 comments

Comments

@mahalakshme
Copy link
Contributor

mahalakshme commented Feb 28, 2024

Issue:

Currently the number of locations that can be downloaded when we do Admin -> Locations -> Click on 'Export' is only 1000 locations.

Technical details:

As per the 'react-admin' documentation here,

The <ExportButton> limits the main request to the dataProvider to 1,000 records. If you want to increase or decrease this limit, pass a maxResults prop to the <ExportButton> in a custom <ListActions> component.

Considering the AdminAppBar shows loading, we can increase the export size to 5000, considering for 1000 it takes around 3-4 secs
Image

Personal notes:

Related ticket: https://avni.freshdesk.com/a/tickets/3603

@ombhardwajj
Copy link
Contributor

@mahalakshme , @vinayvenu I have fixed this issue and created a PR. Please have a look!

@vinayvenu
Copy link
Member

@ombhardwajj I don't think this will work because the server does not support downloading more than 1000, and this is not a setting we would want to change at this point. Closing this card and relevant PR. Thanks for your PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

No branches or pull requests

3 participants