Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove org admin switch when creating user #996

Closed
Tracked by #1206
vinayvenu opened this issue Jul 5, 2023 · 2 comments
Closed
Tracked by #1206

Remove org admin switch when creating user #996

vinayvenu opened this issue Jul 5, 2023 · 2 comments
Assignees

Comments

@vinayvenu
Copy link
Member

Acceptance criteria

  • The "Make this user an administrator ..." switch is removed from the Users screen
  • The "Role" column is removed from the User listing screen
  • API will still accept the role flag, but valid values will be only user and admin
  • Migrate all org-admin values in the database to "user" (need to check if this is possible)

We will eventually replace this with the groups that a user has access to.

@petmongrels
Copy link
Contributor

petmongrels commented Jul 10, 2023

removing most preauthorise from server. removed admin and org_admin completely as role. only one role left 'user'.

  1. 'user' role disallows admin to make transaction data view and save
  2. for 'admin' only endpoints putting a check for isAdmin via accessControlService

@petmongrels
Copy link
Contributor

petmongrels commented Jul 10, 2023

  • instead of creating new privilege for these, using org config privilege - news, msg91config, task type, rule edit, metadata image.
  • for privacy reasons applied edituserconfig privilege for viewing other users.
  • adding Report (entity type = subject) and EditVideo privilege type. used entity type subject instead of creating one more entity type. we will have to change it based on how we want to show it on the UI

petmongrels added a commit to avniproject/avni-server that referenced this issue Jul 11, 2023
…ecurity roles. added Privilege type for report and edit video. applied privilege check where preauthorise check was removed for check is required.
petmongrels added a commit to avniproject/avni-server that referenced this issue Jul 11, 2023
… logic. removed operational ids check, depending only on form mapping.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

No branches or pull requests

2 participants