Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Assign groups when creating user on the Admin screen #997

Closed
8 tasks done
Tracked by #1206
vinayvenu opened this issue Jul 5, 2023 · 7 comments
Closed
8 tasks done
Tracked by #1206

Assign groups when creating user on the Admin screen #997

vinayvenu opened this issue Jul 5, 2023 · 7 comments
Assignees
@himeshr

Comments

@vinayvenu
Copy link
Member

vinayvenu commented Jul 5, 2023 •
edited by himeshr
Loading

Acceptance criteria

  • When creating or editing a user, there is an option to choose the groups that the user will be part of
  • Saving a user will automatically add users to the marked groups
  • Removing a group from a user will automatically remove the user from the unmarked groups
  • Users will by default be assigned to Everyone group during User creation even if he's not assigned to it by AdminUser on the admin-app
  • The Everyone group will be visible on this screen and is assignable and removable, but users will always be part of this group even if user attempts to remove it. This is due to inability to hide it in ReactAdmin code.
  • Show chips for view of Groups
  • User listing will have a new column "User Groups", which will show all group memberships of the user
  • Add translations for webapp for userGroups
@vinayvenu vinayvenu mentioned this issue Jun 23, 2023
Closed
@himeshr himeshr assigned himeshr and unassigned himeshr Jul 21, 2023
himeshr added a commit that referenced this issue Jul 25, 2023
@himeshr
#997 | User listing will have a new column "User Groups", which will …
3638f2e 
…show all group memberships of the user
himeshr added a commit to avniproject/avni-server that referenced this issue Jul 25, 2023
@himeshr
avniproject/avni-webapp#997 | User listing will have a new column "Us…
5372018 
…er Groups", which will show all group memberships of the user
himeshr added a commit that referenced this issue Jul 26, 2023
@himeshr
Revert "#997 | User listing will have a new column "User Groups", whi…
9623d7c 
…ch will show all group memberships of the user"

This reverts commit 3638f2e.
himeshr added a commit that referenced this issue Jul 26, 2023
@himeshr
#997 | Fixed User listing will have a new column "User Groups", which…
ad5fb10 
… will show all group memberships of the user
himeshr added a commit to avniproject/avni-server that referenced this issue Jul 26, 2023
@himeshr
Revert "avniproject/avni-webapp#997 | User listing will have a new co…
2d8e886 
…lumn "User Groups", which will show all group memberships of the user"

This reverts commit 5372018.
himeshr added a commit to avniproject/avni-server that referenced this issue Jul 26, 2023
@himeshr
avniproject/avni-webapp#997 | Code changes to support assignment/un-a…
1c4f64c 
…ssignment of user to groups
himeshr added a commit that referenced this issue Jul 27, 2023
@himeshr
#997 | Code changes to support assignment/un-assignment of user to gr…
36c2ec5 
…oups
himeshr added a commit that referenced this issue Jul 27, 2023
@himeshr
#997 | Code changes to Show Group names within Chip
782337c
himeshr added a commit to avniproject/avni-server that referenced this issue Jul 27, 2023
@himeshr
avniproject/avni-webapp#997 | Code changes to handle voided groups an…
a7f0f33 
…d UserGroups in Groups edit and Users edit screens
himeshr added a commit that referenced this issue Jul 27, 2023
@himeshr
#997 | Rename ReactAdmin resource groups to group
6f786aa
himeshr added a commit to avniproject/avni-server that referenced this issue Jul 27, 2023
@himeshr
avniproject/avni-webapp#997 | Refactor method name to findByUser_IdAn…
9d314ed 
…dGroup_IdAndIsVoidedFalse
himeshr added a commit that referenced this issue Jul 27, 2023
@himeshr
#997 | Deactivate hyperlink
b4fbe62
himeshr added a commit that referenced this issue Jul 27, 2023
@himeshr
#997 | Modify Width and margin for userGroup display
cca75c6
himeshr added a commit that referenced this issue Jul 27, 2023
@himeshr
#997 | Add tool-tip
6a258c5
himeshr added a commit that referenced this issue Jul 27, 2023
@himeshr
#997 | Fix users page load break
70263ba
@himeshr
Copy link
Contributor

himeshr commented Jul 27, 2023

Sample screen-recording:

UserScreenGroupUn-assignment.mov

himeshr added a commit to avniproject/avni-server that referenced this issue Jul 28, 2023
@himeshr
avniproject/avni-webapp#997 | Void userGroups where group is voided
31a9573
@vinayvenu
Copy link
Member Author

himeshr added a commit to avniproject/avni-server that referenced this issue Jul 28, 2023
@himeshr
avniproject/avni-webapp#997 | Minor code refactoring to absorb review…
2767b06 
… comments
himeshr added a commit that referenced this issue Jul 28, 2023
@himeshr
#997 | Hide users list if User doesnot have EditUserConfig privilege
c49da86
himeshr added a commit to avniproject/avni-server that referenced this issue Jul 28, 2023
@himeshr
avniproject/avni-webapp#997 | Adding unit tests
8d1c140
@himeshr
Copy link
Contributor

himeshr commented Jul 28, 2023

@vinayvenu Added unit tests and abosrbed all code-review comments

@AchalaBelokar
Copy link

AchalaBelokar commented Jul 31, 2023 •
edited
Loading

  1. User group is showing me mandatory option but when I am not fill anything it is allow me to save.
Screen.Recording.2023-07-31.at.3.14.16.PM.mov

@AchalaBelokar
Copy link

https://docs.google.com/spreadsheets/d/1WRWHgQojYkGtaRAf7dXrj0K_hk9x1vHlBNOq2IstXmY/edit#gid=0 test cases

himeshr added a commit that referenced this issue Jul 31, 2023
@himeshr
#997 | Hide Everyone group in user edit / create screen
7c882a8
himeshr added a commit to avniproject/avni-server that referenced this issue Jul 31, 2023
@himeshr
avniproject/avni-webapp#997 | Hide Everyone group in user edit / crea…
fb59c74 
…te screen
@himeshr
Copy link
Contributor

himeshr commented Jul 31, 2023 •
edited
Loading

Behaviour changes done:

  • Everyone group is removed from the UserGroups select, during create.
  • During edit, it'll be shown, and user can remove it, but, the group will be retained no matter what action user does.
  • UserGroups is no longer mandatory during edit or create.

@AchalaBelokar
Copy link

AchalaBelokar commented Jul 31, 2023 •
edited
Loading

  • I am not able to create a user and I got password before creating the user this issue is fixed by suhas earlier
Screen.Recording.2023-07-31.at.10.59.26.PM.mov

himeshr added a commit to avniproject/avni-server that referenced this issue Aug 1, 2023
@himeshr
avniproject/avni-webapp#997 | Handle null value for GroupsIds during …
5008d9a 
…create of User
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@himeshr himeshr

Labels
None yet
Projects
Avni Product
Archived in project
Milestone
No milestone
Development

No branches or pull requests
4 participants
@petmongrels @vinayvenu @himeshr @AchalaBelokar