Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Error retries for student sync #89

Closed
Tracked by #24
himeshr opened this issue Sep 11, 2023 · 4 comments
Closed
Tracked by #24

Error retries for student sync #89

himeshr opened this issue Sep 11, 2023 · 4 comments
Assignees

Comments

@himeshr
Copy link

himeshr commented Sep 11, 2023

Acceptance criteria

  • If a student sync fails, then it is retried in the ErrorSync flow with the student information fetched using the BQ query given below so that latest information of the student is available to try the sync once again
select c.phone, fr.results, s.inserted_at
from `glific-lms-lahi.918956411022.contacts` c, UNNEST(c.fields) AS s
join `glific-lms-lahi.918956411022.flow_results` fr 
on fr.contact_phone = c.phone 
WHERE
(s.label, s.value) = ('avni_reg_complete', 'Yes')
AND
fr.name = 'Avni Students Registrations Flow'
AND 
fr.id = <flowResultId>
order by s.inserted_at desc
limit 1

  • On Platform errors, prevent the LAHI module from continuing with processing of records.
@vinayvenu vinayvenu added the LAHI label Oct 5, 2023
@vinayvenu vinayvenu changed the title ErrorTypes and overall error handling in LAHI module Error retries for student sync Oct 5, 2023
@petmongrels petmongrels self-assigned this Nov 9, 2023
@petmongrels
Copy link

petmongrels commented Nov 10, 2023

we can do this bit later. after UAT first round is complete

@petmongrels petmongrels removed their assignment Nov 10, 2023
@mahalakshme mahalakshme removed the LAHI label Nov 28, 2023
@petmongrels petmongrels self-assigned this Dec 4, 2023
petmongrels added a commit that referenced this issue Dec 4, 2023
…ging of error records. do not catch throwable. removed avni entity type of lahi type of error.
@mahalakshme
Copy link

@vinayvenu u r reviewing this?

@AchalaBelokar
Copy link

After reset the password the error log is not coming

@petmongrels
Copy link

petmongrels commented Dec 18, 2023 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

No branches or pull requests

5 participants