Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Key-value field: value "false" is shown blank #2633

Open
2 of 4 tasks
sedubois opened this issue Mar 24, 2024 · 5 comments
Open
2 of 4 tasks

Key-value field: value "false" is shown blank #2633

sedubois opened this issue Mar 24, 2024 · 5 comments
Labels
Enhancement New feature or request Help wanted We could use some help with this Javascript Pull requests that update Javascript code

Comments

@sedubois
Copy link
Contributor

Context

When using the key-value JSON field, an object such as {"key"=>false} is shown with a greyed out Value instead of showing false.

System configuration

Avo version: 3.5.4

Rails version: 7.0

Ruby version: 3.3.0

License type

  • Community
  • Pro

Are you using Avo monkey patches, overriding views or view components?

  • Yes. If so, please post code samples.
  • No

Screenshots or screen recordings

Screenshot 2024-03-24 at 21 05 06
Copy link
Contributor

github-actions bot commented Apr 9, 2024

This issue has been marked as stale because there was no activity for the past 15 days.

@github-actions github-actions bot added the Stale label Apr 9, 2024
@Paul-Bob Paul-Bob removed the Stale label Apr 9, 2024
Copy link
Contributor

This issue has been marked as stale because there was no activity for the past 15 days.

@github-actions github-actions bot added the Stale label Apr 25, 2024
@Paul-Bob Paul-Bob removed the Stale label Apr 25, 2024
Copy link
Contributor

This issue has been marked as stale because there was no activity for the past 15 days.

@github-actions github-actions bot added the Stale label May 11, 2024
@Paul-Bob Paul-Bob removed the Stale label May 13, 2024
Copy link
Contributor

This issue has been marked as stale because there was no activity for the past 15 days.

@github-actions github-actions bot added the Stale label May 29, 2024
@adrianthedev adrianthedev added Enhancement New feature or request Help wanted We could use some help with this Javascript Pull requests that update Javascript code and removed Stale labels May 29, 2024
@adrianthedev
Copy link
Collaborator

Yes, this is a good improvement that the key_value field can receive.

We'll merge a PR if we had one.

Approach

The JS should be able to spot the true false values, render them as such with the "false" text and then, when saved, turn that text back into a boolean false value.
Same for true.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Enhancement New feature or request Help wanted We could use some help with this Javascript Pull requests that update Javascript code
Projects
Status: To Do
Development

No branches or pull requests

3 participants