No data when unselecting filtered options for normal filters

[EffpehKah]

Describe the bug

When selecting something in a filter it filters nicely but doesn't show anything if you unselect the before filtered option. (normal filter, not advanced)

Steps to Reproduce

1. Create a working filter with for example boolean options.
2. Select options and filter your data.
3. Untick the before selected options
4. See no data being displayed.

Expected behavior & Actual behavior

When removing the selection it should behave like resetting the entire filter and show all the data that was there before filtering.

Models and resource files

System configuration

Avo version: 3.7.0

Rails version: 7.1.3.2

Ruby version: 3.3.1

License type:

• Community
• Pro
• Advanced

Are you using Avo monkey patches, overriding views or view components?

• Yes. If so, please post code samples.
• No

Impact

• High impact (It makes my app un-usable.)
• Medium impact (I'm annoyed, but I'll live.)
• Low impact (It's really a tiny thing that I could live with.)

Urgency

• High urgency (I can't continue development without it.)
• Medium urgency (I found a workaround, but I'd love to have it fixed.)
• Low urgency (It can wait. I just wanted you to know about it.)

[github-actions]

This issue has been marked as stale because there was no activity for the past 15 days.

[adrianthedev]

This bug is reproduceable on the avodemo app from this URL.

I see what you mean @EffpehKah.

Unfortunately we can't prioritize fixing this right now.
We'd need to "hold the default state" and check that in the JS controller.

The temporary fix is to reset the filters manually from the UI or to update the apply method to take that particular case into consideration and apply the query propery (or not apply the query at all).

I'm closing this to keep the issue queue clean, but let's keep the conversation open.

PS: We will take a PR if anyone wants to fix this.