Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

actions_list.icon not used #2801

Closed
4 of 11 tasks
pjmuller opened this issue May 23, 2024 · 4 comments
Closed
4 of 11 tasks

actions_list.icon not used #2801

pjmuller opened this issue May 23, 2024 · 4 comments
Assignees
Labels
Feature Good first issue Good for newcomers Help wanted We could use some help with this Task Something to get done

Comments

@pjmuller
Copy link

Describe the bug

Using the icon key described in https://docs.avohq.io/3.0/customizable-controls.html#icon does not make any difference

Steps to Reproduce

class Avo::Resources::Person < Avo::BaseResource
  self.index_controls = -> do
    actions_list style: :primary, color: :primary, icon: "heroicons/outline/envelope", label: "blabla" 
  end

Expected behavior & Actual behavior

icon attribute to work

System configuration

Avo version: 3.7.4

License type:

  • Community
  • Pro
  • Advanced

Are you using Avo monkey patches, overriding views or view components?

  • Yes. If so, please post code samples.
  • No

Screenshots or screen recordings

Screenshot 2024-05-23 at 17 20 29

Additional context

Impact

  • High impact (It makes my app un-usable.)
  • Medium impact (I'm annoyed, but I'll live.)
  • Low impact (It's really a tiny thing that I could live with.)

Urgency

  • High urgency (I can't continue development without it.)
  • Medium urgency (I found a workaround, but I'd love to have it fixed.)
  • Low urgency (It can wait. I just wanted you to know about it.)
@adrianthedev
Copy link
Collaborator

FYI, actions_list does not have an icon option.
We'll try to tend to it soon.

@adrianthedev adrianthedev added Feature Help wanted We could use some help with this Good first issue Good for newcomers Task Something to get done labels May 23, 2024
@pjmuller
Copy link
Author

@adrianthedev thanks for the answer, but the documentation is off right?
Screenshot 2024-05-24 at 06 03 11

@adrianthedev
Copy link
Collaborator

You are right. The docs are incorrect. We'll fix that!

@pjmuller
Copy link
Author

pjmuller commented Jun 4, 2024

Thanks, it's fixed ❤️

@pjmuller pjmuller closed this as completed Jun 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature Good first issue Good for newcomers Help wanted We could use some help with this Task Something to get done
Projects
Status: Done
Development

No branches or pull requests

3 participants