Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add documentation for action icons and action divider #185

Closed
wants to merge 3 commits into from

Conversation

gabrielgiroe1
Copy link
Contributor

@gabrielgiroe1 gabrielgiroe1 commented Apr 1, 2024

Screenshot 2024-04-03 at 18 48 56

Copy link

netlify bot commented Apr 1, 2024

Deploy Preview for avo-v2-docs ready!

Name Link
🔨 Latest commit fc99c4e
🔍 Latest deploy log https://app.netlify.com/sites/avo-v2-docs/deploys/660d7eae54c9c000080443d7
😎 Deploy Preview https://deploy-preview-185--avo-v2-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@Paul-Bob Paul-Bob mentioned this pull request Apr 3, 2024
4 tasks
@Paul-Bob Paul-Bob mentioned this pull request Apr 3, 2024
@Paul-Bob
Copy link
Contributor

Paul-Bob commented Apr 3, 2024

Closing in favor of #187 ( couldn't commit on that PR )

@Paul-Bob Paul-Bob closed this Apr 3, 2024
@@ -362,6 +362,47 @@ end
```
:::

:::option `action icons`
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Other labels have only the option name. Theis would be icon

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@adrianthedev the other options on actions are response types I changed the icon an divider location in this PR #187

I couldn't commit to this one

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I get that, but I think we should do the same with these arguments.

Maybe in a docs reorganization?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes agree, just created this issue to track it #195

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants