Skip Decorators: fix issues when setUp or the test function would/would not be run #4528
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Cleber Rosa <crosa@redhat.com>
When no condition for skip exists, the test should *not* be skipped, that is, it should run. But, the current decorator was not executing the decorated function. This was being masqueraded because the default behavior for tests that do nothing is to pass, and by not running the decorated function (the test) it would effectively pass. Now the tests make sure that the test method gets executed (and does a cancel when running it). Signed-off-by: Cleber Rosa <crosa@redhat.com>
This adds a new parameter, which signals how the result of the condition should be evaluated, that is, if it should be negated. This makes all the logic available to the decorator, and will be required later. Signed-off-by: Cleber Rosa <crosa@redhat.com>
There's currently a bug in cause by the fact that the decorator function is always marked (__skip_method_decorator__) to be skipped, even when the condition is supposed to be evaluated later, during the execution of the decorator. This has caused the setUp() method to not be executed in certain cases, and the test method proceeds without finding its environment set up (common situation when not running setUp(), one ends up with missing attributes, in the class and cryptic errors during the execution of the test). This evaluates the same conditions used for skipping the test, but also for skipping the setUp() method. Unfortunately, we have to distinguish between the condition and the decorator itself because if we don't, we may end up running the decorated function (usually the test) twice. Signed-off-by: Cleber Rosa <crosa@redhat.com>
|
Code Climate has analyzed commit 3c3f30d and detected 0 issues on this pull request. The test coverage on the diff in this pull request is 33.3% (50% is the threshold). This pull request will bring the total coverage in the repository to 68.2% (0.0% change). View more on Code Climate. |
|
This was before this fix: And with this fix: |
willianrampazzo
approved these changes
Apr 13, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are two different issues with the skip decorators fixed here: