Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

exist_ok in utils.path.init_dir #5746

Merged
merged 1 commit into from Aug 21, 2023
Merged

Conversation

richtja
Copy link
Contributor

@richtja richtja commented Aug 9, 2023

When we are creating path with utils.path.init_dir method, we might get FileExistsError when part of this directory have already existed. This issue created failure of
selftests.functiona.job_api_features:Test.test_runnable_output_dir test. Let's set exist_ok to True to avoid FileExistsError.

https://download.copr.fedorainfracloud.org/results/packit/avocado-framework-avocado-5744/fedora-38-aarch64/06259385-python-avocado/builder-live.log.gz

When we are creating path with utils.path.init_dir method, we might get
FileExistsError when part of this directory have already existed. This
issue created faluire of
`selftests.functiona.job_api_features:Test.test_runnable_output_dir`
test. Let's set exist_ok to True to avoid FileExistsError.

Signed-off-by: Jan Richter <jarichte@redhat.com>
@richtja richtja added the bug label Aug 9, 2023
@richtja richtja requested a review from clebergnu August 9, 2023 15:52
@richtja richtja self-assigned this Aug 9, 2023
@mr-avocado
Copy link

mr-avocado bot commented Aug 9, 2023

Dear contributor,
Avocado is currently under sprint #103, which is due to release an LTS (Long Term Stability) release.
Please avoid merging changes that do not fall into these categories:

  • Bug fixes
  • Usability Improvements
  • Documentation updates

As for the Avocado utility modules (“avocado.utils”) it is OK to introduce new functionality,
but changes to the existing APIs (including interface and behavior) should be avoided.
These kind of changes should wait until sprint #104.

Copy link
Contributor

@clebergnu clebergnu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@clebergnu clebergnu merged commit ce66639 into avocado-framework:master Aug 21, 2023
59 checks passed
@richtja richtja deleted the arm_fix branch August 28, 2023 08:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

None yet

2 participants