Process Spawner: protect against races between TERM and KILL #5805
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Because a task (usually a test) can simply finish by itself, either before a TERM or between a TERM and a KILL, it's important to protect against the process not existing anymore. File "/Users/runner/work/avocado/avocado/avocado/plugins/spawners/process.py", line 87, in terminate_task runtime_task.spawner_handle.process.kill() File "/Library/Frameworks/Python.framework/Versions/3.11/lib/python3.11/asyncio/subprocess.py", line 143, in kill self._transport.kill() File "/Library/Frameworks/Python.framework/Versions/3.11/lib/python3.11/asyncio/base_subprocess.py", line 153, in kill self._check_proc() File "/Library/Frameworks/Python.framework/Versions/3.11/lib/python3.11/asyncio/base_subprocess.py", line 142, in _check_proc raise ProcessLookupError() The following is an exercept from a stacktrace when the situation hits. Signed-off-by: Cleber Rosa <crosa@redhat.com>
|
Dear contributor,
As for the Avocado utility modules (“avocado.utils”) it is OK to introduce new functionality, |
richtja
approved these changes
Nov 16, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Because a task (usually a test) can simply finish by itself, either before a TERM or between a TERM and a KILL, it's important to protect against the process not existing anymore.
File "/Users/runner/work/avocado/avocado/avocado/plugins/spawners/process.py",
line 87, in terminate_task
runtime_task.spawner_handle.process.kill()
File "/Library/Frameworks/Python.framework/Versions/3.11/lib/python3.11/asyncio/subprocess.py",
line 143, in kill
self._transport.kill()
File "/Library/Frameworks/Python.framework/Versions/3.11/lib/python3.11/asyncio/base_subprocess.py",
line 153, in kill
self._check_proc()
File "/Library/Frameworks/Python.framework/Versions/3.11/lib/python3.11/asyncio/base_subprocess.py",
line 142, in _check_proc
raise ProcessLookupError()
The following is an exercept from a stacktrace when the situation hits.