Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Method for optimizing data structure functions #5863

Merged
merged 1 commit into from
Feb 26, 2024
Merged

Method for optimizing data structure functions #5863

merged 1 commit into from
Feb 26, 2024

Conversation

ut003460
Copy link
Contributor

@ut003460 ut003460 commented Feb 5, 2024

1.The extend() method was used to add the entire range of values at once, rather than adding them one by one. This can reduce the number of loops and the creation of temporary lists

Copy link
Contributor

@richtja richtja left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @ut003460, thank you for this optimization. IMO, it is almost completed. The CI failure is not related to your PR, but I have just a few questions because I think that some of those changes are not needed.

avocado/utils/data_structures.py Outdated Show resolved Hide resolved
avocado/utils/data_structures.py Show resolved Hide resolved
avocado/utils/data_structures.py Outdated Show resolved Hide resolved
@clebergnu
Copy link
Contributor

/packit copr-build

@richtja
Copy link
Contributor

richtja commented Feb 6, 2024

Hi @ut003460 thank you for the update to the code LGTM. Can you please squash the update commit to the previous one? Thank you.

You can do it with git rebase -i HEAD~1 and then mark the update commit as fixup

1.The extend() method was used to add the entire range of values at once, rather
than adding them one by one. This can reduce the number of loops and the
creation of temporary lists

Signed-off-by: ut003460 <xiongneng@uniontech.com>
Copy link
Contributor

@richtja richtja left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ut003460 thank you.

@richtja richtja merged commit 33d276a into avocado-framework:master Feb 26, 2024
59 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

None yet

3 participants